Menu
▾
▴
[Mingw-notify] [ mingw-Patches-1223109 ] Change File System access model for single user file systems
|
From: SourceForge.net <no...@so...> - 2005-07-02 08:07:30
|
Patches item #1223109, was opened at 2005-06-18 06:22 Message generated for change (Comment added) made by mtew You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1223109&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: msys Group: Patch contains errors >Status: Open Resolution: None Priority: 5 Submitted By: Max TenEyck Woodbury (mtew) Assigned to: Earnie Boyd (earnie) Summary: Change File System access model for single user file systems Initial Comment: Some of the file systems that MSYS can access are designed for use by only one user. The MSYS run time currently maps access to such a file system to one that allows everyone to have the same access as everyone else. These patches change that mapping to one with access restricted to a single user but with everyone's access aliased to that user. This produces a more consistant model of what acctualy is taking place when such a file system is used. (Specifically, the old scheme implied that there was an individual and group identifier associated with each file or directory and that by implication those identifiers could be changed. The alternate scheme implies that you can not change the identifiers.) Note that there are three patches. The sec_acl.cc patch is a technical correction to the interpretation of access descriptor strings. There are in fact four possible characters that can appear in the third position of an access triplet string, not two. Asside from the common 'x' and '-' values, there are also 's' and 'S' values that have the same execute attributes as 'x' and '-' respectively, but also indicate that the corresponding 'sticky bit' is set. The change allows for the alternate 'x' coding. The 'sticky bit' encoding is ignored because impimenting it would require changes to the calling routines as well as changes to this routine. The fhandler.cc patch implements the modified scheme for files. It removes apparent 'group' and 'other' access to files. In fact this does not change the actual access semantics since the UID of everything on a single user file system is implictly the current UID. A secondary correction in this file corrects the calculation of the total amount of space available on volume which might be larger than 4GB. The syscalls.cc patch implements the modified scheme for directories. It also removes 'group' and 'other' access, but indicates that 'group' and 'user' ids will not be set 'properly' on and can not be changed for any files in those directories. ... Sorry - system trouble. I'll have to shut down and add the actual patches and change log entry later... ---------------------------------------------------------------------- >Comment By: Max TenEyck Woodbury (mtew) Date: 2005-07-02 04:07 Message: Logged In: YES user_id=735003 It's your call of course, but on a FAT file system on a W9x or ME system there is no 'group' or 'others', only the 'owner' so what is set for the group and other permissions really makes no difference. Saying that 'group' and 'others' have no access makes the security test in 'ssh' passable where it would not otherwise be. On NT where there are other 'group's and 'other's, this patch should have no effect. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2005-07-01 23:39 Message: Logged In: YES user_id=15438 Your fhandler.cc changes are not correct w.r.t. st->mode. Since group and others can read the files it is most definitely correct to display the bits so they do. Earnie ---------------------------------------------------------------------- Comment By: Max TenEyck Woodbury (mtew) Date: 2005-06-18 14:06 Message: Logged In: YES user_id=735003 2005.06.18 Max Woodbury <mt...@us...> * fhandler.cc(fhandler_disk_file::fstat) - change file access model * fhandler.cc(fhandler_disk_file::fstat) - fix size calc if > 4GB. * sec_acl.cc(permfromstr) - addes 's' as an alternate to 'x' in access strings. * syscalls.cc(stat_worker) - change directory access model. Note: the access semantics have not changed. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2005-06-18 08:44 Message: Logged In: YES user_id=15438 You need to study on a proper ChangeLog entry. You're close but the syntax is wrong enough to be obvious. I'll try to find the reference document; but you should be able to look at the existing ChangeLog and spot obvious differences. ---------------------------------------------------------------------- Comment By: Max TenEyck Woodbury (mtew) Date: 2005-06-18 07:04 Message: Logged In: YES user_id=735003 2005.06.18 Max Woodbury <mt...@us...> * fhandler.cc - change file access model, fix size calc if > 4GB. * sec_acl.cc - addes 's' as an alternate to 'x' in access strings. * syscalls.cc - change directory access model. - Note: the access semantics have not changed. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1223109&group_id=2435 |