From: Luke D. <cod...@ho...> - 2005-10-30 06:52:49
|
----- Original Message ----- From: "Danny Smith" <dan...@cl...> To: "mingw-dvlpr" <min...@li...> Sent: Sunday, October 30, 2005 10:11 AM Subject: [MinGW-dvlpr] OBJBASE_H_? > This recent commit: by Chris S > =================================================================== > RCS file: /cvs/src/src/winsup/w32api/include/objbase.h,v > retrieving revision 1.14 > retrieving revision 1.15 > diff -u -r1.14 -r1.15 > --- src/winsup/w32api/include/objbase.h 2005/09/08 13:52:48 1.14 > +++ src/winsup/w32api/include/objbase.h 2005/10/30 00:07:58 1.15 > @@ -4,7 +4,7 @@ > #include <rpcndr.h> > > #ifndef _OBJBASE_H > -#define _OBJBASE_H_ > +#define _OBJBASE_H > #if __GNUC__ >=3 > #pragma GCC system_header > #endif > > gets us back to the objbase.h header guard before this > 2004-04-24 Luke Dunstan <in...@us...> > * include/objbase.h (_OBJBASE_H_): Define. > > which was followed by this incorrect reversion of the above > 2005-09-08 Dimitri Papadopoulos <pap...@us...> > * include/objbase.h: Avoid double header guard. > > > Luke, > What was reason for your patch to add _OBJBASE_H_? Is that reason still > valid? > > Danny I believe it was necessary to compile a C++ library that was part of the DirectX 9 SDK. I would prefer to revert back to before both of the above patches, unless there is a specific reason not to #define _OBJBASE_H_ Luke |