Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#2167 WSL: regression: make install-includes misplaces DirectX headers

WSL
unread
nobody
None
Bug
none
Unknown
False
2014-03-23
2014-01-12
Keith Marshall
No

In w32api-3.x, the "make install-headers" goal (correctly) placed the DirectX headers directly into ${includedir}.

WSL renames "install-headers" as "install-includes, (itself a regression; cf. [#2166]). This (rewritten) goal (incorrectly) attempts to place these headers into directory ${includedir}/directx. If this ${includedir}/directx directory already exists, the headers are incorrectly installed within it; if it does not exist, (cf. [#2165]), the DirectX headers are simply not installed ... rather they overwrite one another, leaving the last -- in collating order -- in the file ${includedir}/directx

Related

Issues: #2165
Issues: #2166
Issues: #2202

Discussion

  • Keith Marshall
    Keith Marshall
    2014-01-12

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,3 +1,3 @@
     In w32api-3.x, the "make install-headers" goal (correctly) placed the DirectX headers directly into ${includedir}.
    
    -WSL renames "install-headers" as "install-includes, (itself a regression; c.f. [#2166]).  This (rewritten) goal (incorrectly) attempts to place these headers into directory ${includedir}/directx.  If this ${includedir}/directx directory already exists, the headers are incorrectly installed within it; if it does not exist, (c.f. [#2165]), the DirectX headers are simply **not** installed ... rather they overwrite one another, leaving the last -- in collating order -- in the **file** ${includedir}/directx
    +WSL renames "install-headers" as "install-includes, (itself a regression; cf. [#2166]).  This (rewritten) goal (incorrectly) attempts to place these headers into directory ${includedir}/directx.  If this ${includedir}/directx directory already exists, the headers are incorrectly installed within it; if it does not exist, (cf. [#2165]), the DirectX headers are simply **not** installed ... rather they overwrite one another, leaving the last -- in collating order -- in the **file** ${includedir}/directx
    
     
  • Keith Marshall
    Keith Marshall
    2014-03-23

    As noted in [#2202], (which I've marked as a duplicate of this), a similar issue exists in the case of the GL headers; these overwrite one another to create only a single ${prefix}/include/GL file. This requires the converse of the DirectX resolution: the GL headers should be placed in a ${prefix}/include/GL directory.

     

    Related

    Issues: #2202