Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#2051 mingw-get[GUI]:on meta-package removal, status not updated

INSTALLER
closed
None
Bug
fixed
IINR_-_Include_In_Next_Release
False
2013-09-21
2013-09-17
Keith Marshall
No

On applying changes, after marking any virtual package for removal, the status flag is not properly updated to reflect successful removal. Consequently, the action is reported as "failed", without explanation (because there was no actual failure), and the package remains marked for pending removal, (even though it is no longer installed, as can be seen by manually "unmarking" it).

Discussion

  • Keith Marshall
    Keith Marshall
    2013-09-19

    This is caused by a logic error in function pkgRemove(), (in src/pkgunst.cpp). When a package is identified as "virtual", the associated manifest processing is skipped, (because virtual packages have no manifest), but it was during manifest processing only that the "action pending" flag was being cleared.

    The solution is for pkgRemove() to explicitly clear the "action pending" flag, as soon as a package is identified as "virtual".

     
    Last edit: Keith Marshall 2013-09-19
  • Keith Marshall
    Keith Marshall
    2013-09-19

    • status: assigned --> open
    • Category: Unknown --> IINR_-_Include_In_Next_Release
     
  • Keith Marshall
    Keith Marshall
    2013-09-20

    I've now committed the identified fix for this, to the origin repository; it will be incorporated into mingw-get-0.6.2

     
  • Keith Marshall
    Keith Marshall
    2013-09-21

    • status: open --> closed
    • Resolution: none --> fixed