#1958 __GNUC_MINOR__ filter is incorrect.

WSL
closed
Earnie Boyd
_mingw.h (1)
Task
fixed
Feature_in_WSL_4.0
False
2013-05-15
2013-04-23
Earnie Boyd
No

I did notice one minor detail. In /mingw/include/_mingw.h it says

#if (__GNUC__ < 3 || !defined(__GNUC_MINOR__) || (__GNUC__ == 3 &&
__GNUC_MINOR__ < 4) || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4 &&
__GNUC_PATCHLEVEL__ < 5))
#error ERROR: You must use a GNU Compiler version >= 3.4.5.
#endif

That __GNUC_MINOR__ >= 4 should perhaps be __GNUC_MINOR__ == 4. Right
now a hypothetical gcc 3.5.0 would give the error message. Of course,
there is no gcc 3.5.x (as 4.0.x came after 3.4.x), so there is not
really any problem.
--George Koehler

Discussion

  • Earnie Boyd
    Earnie Boyd
    2013-04-23

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -8,7 +8,7 @@
     #endif
    

    -That GNUC_MINOR >= 4 should perhaps be GNUC_MINOR == 4. Right
    +That __GNUC_MINOR__ >= 4 should perhaps be __GNUC_MINOR__ == 4. Right
    now a hypothetical gcc 3.5.0 would give the error message. Of course,
    there is no gcc 3.5.x (as 4.0.x came after 3.4.x), so there is not
    really any problem.

     
  • Earnie Boyd
    Earnie Boyd
    2013-05-15

    • status: assigned --> closed
    • Type: Support --> Task
    • Resolution: none --> fixed
    • Category: Unknown --> Feature_in_WSL_4.0