#1802 patch: fix quoting and handle spaces in path gracefully

MSYS
open
Cesar Strauss
msys.bat (3)
Task
none
Unknown
True
2013-02-13
2009-06-19
Hamish B
No

[this is a round-up of patches for ID: 1511614 and ID: 1840961. Cesar asked that I start a new ticket with the patch. explanation copied below]

Hi,

the attached patch fixes quoting problems in msys.bat AND adds the following:

+for /F %%i IN ('echo %WD%') DO @set PART1=%%i
+if NOT "%PART1%" == "%WD%" (
+ echo Path names containing spaces are not supported -- aborting.
+ pause
+ exit 1
+)

if the user decides to remove that, well they can expect about as much
recourse from the manufacturer as if they had unwelded the seat belts from
their car to save weight, and they'll know it.

this way we can work on finding and fixing the quoting problems in the
background without you guys getting flooded with support requests for an
issue which isn't necessarily a useful sink of your time.

at minimum at least with this patch it'll fail cleanly & obviously if the
user ignores your prior warnings.

regards,
Hamish

Discussion

  • Hamish B
    Hamish B
    2009-06-19

    patch: fix quoting and handle spaces in path gracefully

     
    Attachments
  • Cesar Strauss
    Cesar Strauss
    2010-01-31

    • assigned_to: nobody --> cstrauss
     
  • Cesar Strauss
    Cesar Strauss
    2010-01-31

    • labels: 380073 --> msys
     
  • Earnie Boyd
    Earnie Boyd
    2013-01-11

    • milestone: --> Aged_issue
    • status: open --> pending-out-of-date
     
  • Hamish B
    Hamish B
    2013-02-02

    [see ongoing disucssion in #1109 "error if msys is installed in directory with spaces"]

    to reiterate, the primary purpose of this patch is to at least make the thing fail gracefully if the msys devs decide not to do anything about the quoted path name problem. (which IMNSHO is just good defensive coding practice regardless of the platform)

    regards,
    Hamish

     
  • Earnie Boyd
    Earnie Boyd
    2013-02-13

    Ticket moved from /p/mingw/patches/416/

     
  • Earnie Boyd
    Earnie Boyd
    2013-02-13

    • labels: msys --> msys.bat
    • status: pending-out-of-date --> open
    • milestone: Aged_issue --> MSYS
    • type: --> Task
    • resolution: --> none
    • category: --> Unknown
    • patch_attached: --> True