#1758 copy inputrc independent of the presence of $HOME

MSYS
pending
Cesar Strauss
None
Task
none
Unknown
True
2013-02-12
2012-02-28
Fabian Greffrath
No

Hi,

currently, /etc/profile checks for the existence of a $HOME directory and if it does not exist, creates it and copies /etc/inputrc.default to "$HOME"/.inputrc.

However, sometimes I install MSYS and have already set the $HOME variable to another directory. Thus the .inputrc file is not copied over.

I suggest to make the copying of .inputrc independent of the presence of the HOME directory, but actually check for the presence of this very file instead. the attached patch against /etc/profile does this.

Discussion

  • In /etc/profile, copy inputrc independent of the presence of $HOME, but actually check for the presence of the file itself

     
    Attachments
  • Earnie Boyd
    Earnie Boyd
    2012-02-28

    I haven't checked the patch but sort-of like the idea. I do question though that the user should have the right to not want ~/.inputrc if he choose that but an empty file should overcome that case.

     
  • Earnie Boyd
    Earnie Boyd
    2012-02-28

    • assigned_to: nobody --> cstrauss
     
  • Earnie Boyd
    Earnie Boyd
    2012-02-28

    • labels: 380073 --> msys
     
  • > I haven't checked the patch but sort-of like the idea.

    It's only three added lines.

    > I do question though
    > that the user should have the right to not want ~/.inputrc if he
    > choose that but an empty file should overcome that case.

    With the patch, everything behaves as before. It only adds support for an additional use case, i.e. when $HOME is already present but does not contain ~/.inputrc. And even in this case, if you happen to not want that file (for whatever weird reasons), you can empty or comment it out entirely.

    What does Cesar thing?

     
  • Cesar Strauss
    Cesar Strauss
    2012-03-06

    • milestone: --> IINR_-_Include_In_Next_Release
     
  • Cesar Strauss
    Cesar Strauss
    2012-03-06

    Seems reasonable. I'll include it when I get the chance.

    Thanks,

    Cesar

     
  • > Seems reasonable. I'll include it when I get the chance.

    *cough* ;)

     
  • Earnie Boyd
    Earnie Boyd
    2012-04-05

    Pest. ;D

    A release for just this change is not likely to happen in the near future. When Cesar said "when I get a chance" he didn't mean any time soon and it has only been a month.

     
  • > A release for just this change is not likely to happen in the near future.
    > When Cesar said "when I get a chance" he didn't mean any time soon and it
    > has only been a month.

    Now it's three more months. I have never expected a new release just for this trivial patch, but I somehow expected it to get commited in CVS within a reasonable time frame. Telling "Yes, thanks, later..." is a perfect means to scare off new contributors, btw.

     
  • Earnie Boyd
    Earnie Boyd
    2013-02-12

    Ticket moved from /p/mingw/patches/512/

     
  • Earnie Boyd
    Earnie Boyd
    2013-02-12

    Cesar is this closable?

     
  • Earnie Boyd
    Earnie Boyd
    2013-02-12

    • labels: msys -->
    • status: open --> pending
    • milestone: IINR_-_Include_In_Next_Release --> MSYS
    • type: --> Task
    • resolution: --> none
    • category: --> Unknown
    • patch_attached: --> True