Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#1700 basic unicode support patch for msys-1.18-1

MSYS
assigned
Cesar Strauss
Feature
rejected
Unknown
True
2013-05-07
2013-02-07
ralph engels
No

Based on kbless basic unicode support patchset from msysgit, Credits for the initial work belongs to him.

Changes.
Rearranged some of the new api headers because of build problems otherwise.
Changed newlibs local.h to not include wchar.h because its not imported correctly that early in the build and causes errors
with mbstate_t not being defined properly. Moved a local copy of the wchar.h contents to local.h instead.
Added stdint.h and inttypes.h from cygwin 1.5 and fixed guards so the inttypes dont conflict with the ones in sys/types.h and machine/types.h .
Added network interfaces from cygwin 1.5.
Added strtoll and strtoull from cygwin 1.5.
Added the kill.exe function from msysgit.
Removed the strtoull compat function from kill.exe (no longer nessesary with new support).
Removed newlib.h from kbless patch (was not used anywhere).
Removed the unicode function wrappers from kbless patch since atleast gcc 3.4.4 and later cannot compile it,
besides it seems to work just as well without them.
Added nl_langinfo support (experimental may remove if it behaves abnormally).
Fixed a few weak exports from msys pthread functions.
Fixed a bunch of stuff to allow compiling the msys dll with gcc version 4 (cygcheck still links to libstdc++ investigating why).
Changed a few math functions from newlib to use _Ulong instead of _uint32_t (cygwin 1.5).

Big thanks to kbless for the initiall patch it helped a lot.

The folder inside this archive contains a batch script + some tools needed to patch an unmodified source dir
from the msysCORE-1.0.18-1-msys-1.0.18-src.tar.lzma archive.
besides unpacking the source its all automated so it should be pretty straight forward.

unpack this archive somewhere and extract the source directory from the msysCORE-1.0.18-1-msys-1.0.18-src.tar.lzma archive,
to where you unpacked this. Now run patcher.bat (just doubleclick it) and follow the directions.
Now unpack msysCORE-1.0.18-1-msys-1.0.18-src.tar.lzma where you want to build it and replace the source dir inside it with the patched one from here.
Open an msys shell (you need the msysdev package) and be sure its set to MSYS. Cd to the dir where the builddir is and run
./msysrlsbld. When done you should have a bunch of tar archives and an nstl directory. Close the msys shell and copy the contents of the nstl dir
to where your msys is installed. Open a shell again and try building something with multibyte support.

Revelator

1 Attachments

Related

Issues: #1700

Discussion

1 2 > >> (Page 1 of 2)
  • Earnie Boyd
    Earnie Boyd
    2013-02-07

    • labels: basic unicode support --> unicode, locale, codepage
    • status: unread --> assigned
    • assigned_to: Cesar Strauss
    • category: Future_MSYS_enhancement --> Unknown
     
  • Earnie Boyd
    Earnie Boyd
    2013-02-07

    • labels: unicode, locale, codepage --> unicode, locale, code page
     
  • ralph engels
    ralph engels
    2013-02-09

    Fixed the wrapper code, problem was that macros depended on the utftowcns function which should have been imported from unicode.h but somehow it was not. i split the utf wrapper code into a seperate wrapper.c file and added it to makefile.in and it works now.

    preparing a small patch.

     
  • Earnie Boyd
    Earnie Boyd
    2013-02-09

    Can you attach the patch as plain text file? If you must compress it please use bzip2 or xz instead of 7z.

     
  • ralph engels
    ralph engels
    2013-02-09

    Sure here you go.

     
    Attachments
  • ralph engels
    ralph engels
    2013-02-09

    Sure its only two files that need modifying :) makefile.in and the new
    file wrapper.c.

    Den 09-02-2013 18:30, Earnie Boyd skrev:

    Can you attach the patch as plain text file? If you must compress it
    please use bzip2 or xz instead of 7z.


    [bugs:#1700] http://sourceforge.net/p/mingw/bugs/1700/ basic
    unicode support patch for msys-1.18-1

    Status: assigned
    Labels: unicode locale code page
    Created: Thu Feb 07, 2013 09:05 PM UTC by ralph engels
    Last Updated: Sat Feb 09, 2013 12:20 PM UTC
    Owner: Cesar Strauss

    Based on kbless basic unicode support patchset from msysgit, Credits
    for the initial work belongs to him.

    Changes.
    Rearranged some of the new api headers because of build problems
    otherwise.
    Changed newlibs local.h to not include wchar.h because its not
    imported correctly that early in the build and causes errors
    with mbstate_t not being defined properly. Moved a local copy of the
    wchar.h contents to local.h instead.
    Added stdint.h and inttypes.h from cygwin 1.5 and fixed guards so the
    inttypes dont conflict with the ones in sys/types.h and machine/types.h .
    Added network interfaces from cygwin 1.5.
    Added strtoll and strtoull from cygwin 1.5.
    Added the kill.exe function from msysgit.
    Removed the strtoull compat function from kill.exe (no longer
    nessesary with new support).
    Removed newlib.h from kbless patch (was not used anywhere).
    Removed the unicode function wrappers from kbless patch since atleast
    gcc 3.4.4 and later cannot compile it,
    besides it seems to work just as well without them.
    Added nl_langinfo support (experimental may remove if it behaves
    abnormally).
    Fixed a few weak exports from msys pthread functions.
    Fixed a bunch of stuff to allow compiling the msys dll with gcc
    version 4 (cygcheck still links to libstdc++ investigating why).
    Changed a few math functions from newlib to use _Ulong instead of
    _uint32_t (cygwin 1.5).

    Big thanks to kbless for the initiall patch it helped a lot.

    The folder inside this archive contains a batch script + some tools
    needed to patch an unmodified source dir
    from the msysCORE-1.0.18-1-msys-1.0.18-src.tar.lzma archive.
    besides unpacking the source its all automated so it should be pretty
    straight forward.

    unpack this archive somewhere and extract the source directory from
    the msysCORE-1.0.18-1-msys-1.0.18-src.tar.lzma archive,
    to where you unpacked this. Now run patcher.bat (just doubleclick it)
    and follow the directions.
    Now unpack msysCORE-1.0.18-1-msys-1.0.18-src.tar.lzma where you want
    to build it and replace the source dir inside it with the patched one
    from here.
    Open an msys shell (you need the msysdev package) and be sure its set
    to MSYS. Cd to the dir where the builddir is and run
    ./msysrlsbld. When done you should have a bunch of tar archives and an
    nstl directory. Close the msys shell and copy the contents of the nstl dir
    to where your msys is installed. Open a shell again and try building
    something with multibyte support.

    Revelator


    Sent from sourceforge.net because you indicated interest in
    https://sourceforge.net/p/mingw/bugs/1700/

    To unsubscribe from further messages, please visit
    https://sourceforge.net/auth/prefs/

     

    Related

    Issues: #1700

  • Earnie Boyd
    Earnie Boyd
    2013-02-11

    • resolution: none --> rejected
     
  • ralph engels
    ralph engels
    2013-02-12

    Must have misunderstood then i thought you wanted it as a plain text
    file ? do you refer to the last one.
    if you refer to my patcher its because i foolishly used astyle to format
    the sources so it wont apply cleanly
    to an unmodified version. Ill do a git version old one was just made
    with plain diff.exe from msys itself.

    Den 11-02-2013 13:23, Earnie Boyd skrev:

    The file you attached isn't a patch. Please use git to create a diff
    file for the repository at
    https://sourceforge.net/p/mingw/msys-runtime/ci/77f2469b25911ceebae6741cbd2fa1b0ff6b1d6e/tree/
    so that we can apply it properly.


    [bugs:#1700] http://sourceforge.net/p/mingw/bugs/1700/ basic
    unicode support patch for msys-1.18-1

    Status: assigned
    Labels: unicode locale code page
    Created: Thu Feb 07, 2013 09:05 PM UTC by ralph engels
    Last Updated: Sat Feb 09, 2013 07:14 PM UTC
    Owner: Cesar Strauss

    Based on kbless basic unicode support patchset from msysgit, Credits
    for the initial work belongs to him.

    Changes.
    Rearranged some of the new api headers because of build problems
    otherwise.
    Changed newlibs local.h to not include wchar.h because its not
    imported correctly that early in the build and causes errors
    with mbstate_t not being defined properly. Moved a local copy of the
    wchar.h contents to local.h instead.
    Added stdint.h and inttypes.h from cygwin 1.5 and fixed guards so the
    inttypes dont conflict with the ones in sys/types.h and machine/types.h .
    Added network interfaces from cygwin 1.5.
    Added strtoll and strtoull from cygwin 1.5.
    Added the kill.exe function from msysgit.
    Removed the strtoull compat function from kill.exe (no longer
    nessesary with new support).
    Removed newlib.h from kbless patch (was not used anywhere).
    Removed the unicode function wrappers from kbless patch since atleast
    gcc 3.4.4 and later cannot compile it,
    besides it seems to work just as well without them.
    Added nl_langinfo support (experimental may remove if it behaves
    abnormally).
    Fixed a few weak exports from msys pthread functions.
    Fixed a bunch of stuff to allow compiling the msys dll with gcc
    version 4 (cygcheck still links to libstdc++ investigating why).
    Changed a few math functions from newlib to use _Ulong instead of
    _uint32_t (cygwin 1.5).

    Big thanks to kbless for the initiall patch it helped a lot.

    The folder inside this archive contains a batch script + some tools
    needed to patch an unmodified source dir
    from the msysCORE-1.0.18-1-msys-1.0.18-src.tar.lzma archive.
    besides unpacking the source its all automated so it should be pretty
    straight forward.

    unpack this archive somewhere and extract the source directory from
    the msysCORE-1.0.18-1-msys-1.0.18-src.tar.lzma archive,
    to where you unpacked this. Now run patcher.bat (just doubleclick it)
    and follow the directions.
    Now unpack msysCORE-1.0.18-1-msys-1.0.18-src.tar.lzma where you want
    to build it and replace the source dir inside it with the patched one
    from here.
    Open an msys shell (you need the msysdev package) and be sure its set
    to MSYS. Cd to the dir where the builddir is and run
    ./msysrlsbld. When done you should have a bunch of tar archives and an
    nstl directory. Close the msys shell and copy the contents of the nstl dir
    to where your msys is installed. Open a shell again and try building
    something with multibyte support.

    Revelator


    Sent from sourceforge.net because you indicated interest in
    https://sourceforge.net/p/mingw/bugs/1700/

    To unsubscribe from further messages, please visit
    https://sourceforge.net/auth/prefs/

     

    Related

    Issues: #1700

    • Earnie Boyd
      Earnie Boyd
      2013-02-12

      I want you to git clone the repository, make your changes, do a git diff to create the patch file and then attach that as a plain text file. And please call it .patch or .diff without a .txt extension.

       
1 2 > >> (Page 1 of 2)