Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#2 Remove dead code in shell32.c

closed-fixed
NightStrike
None
5
2008-04-27
2008-04-25
NightStrike
No

There is a large segment of code surrounded by "#if 0" in shell32.c. This patch removes it.

Discussion

  • NightStrike
    NightStrike
    2008-04-25

    shell32.c patch file

     
    Attachments
  • Kai Tietz
    Kai Tietz
    2008-04-25

    Logged In: YES
    user_id=1598680
    Originator: NO

    Please replace DEFINE_SHLGUID by DEFINE_GUID and remove the #if 0
    The uuid's are needed.

     
  • NightStrike
    NightStrike
    2008-04-25

    • assigned_to: nobody --> nightstrike
    • status: open --> closed-fixed
     
  • NightStrike
    NightStrike
    2008-04-25

    Logged In: YES
    user_id=1864092
    Originator: YES

    Done on rev 371

     
  • NightStrike
    NightStrike
    2008-04-26

    Logged In: YES
    user_id=1864092
    Originator: YES

    Ok, all sorts of stuff blows up when I enable this code as you suggested. I put it back to #if 0 in svn. I think that either we should remove it entirely or enable it so that it works, not leave it disabled.

     
  • NightStrike
    NightStrike
    2008-04-26

    • status: closed-fixed --> open-postponed
     
  • Kai Tietz
    Kai Tietz
    2008-04-27

    Logged In: YES
    user_id=1598680
    Originator: NO

    Committed revision 379.

     
  • Kai Tietz
    Kai Tietz
    2008-04-27

    • status: open-postponed --> closed-fixed