Re: [Mingw-w64-public] [Patch] More annotations in sal.h and driverspecs.h

[Jacek C. <ja...@co...>]

Hi,

We don't share those parts. The patch looks mostly good to me except for
comments. Those are C++/C99 comments, please use /* */ for C89
compatibility.

Thanks,
Jacek

On 08/29/15 18:02, Kai Tietz wrote:
> Hi,
>
> in general this patch looks ok to me.  As we share here parts with
> Wine, I am interested in Jacek's opinion on it too.
>
> Thanks,
> Kai
>
> 2015-08-28 19:48 GMT+02:00 David Grayson <dav...@gm...>:
>> Hello. The attached patch adds several simple macro definitions to sal.h and
>> driverspecs.h.  The patch to sal.h contains all of the macros documented on
>> these two pages:
>>
>> https://msdn.microsoft.com/en-us/library/hh916382.aspx
>> https://msdn.microsoft.com/en-us/library/jj159529.aspx
>>
>> In addition, this patch adds some undocumented macros to sal.h and
>> driverspecs.h that are needed to compile usbview and devcon (two example
>> applications destributed by Microsoft).  If someone could apply this patch
>> or give me feedback about how to improve them, that would be great!
>>
>> --David
>>
>> ------------------------------------------------------------------------------
>>
>> _______________________________________________
>> Mingw-w64-public mailing list
>> Min...@li...
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>
> ------------------------------------------------------------------------------
> _______________________________________________
> Mingw-w64-public mailing list
> Min...@li...
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public