Re: [Mingw-w64-public] [PATCH] Mark msvcr90 functions which also provide in libmingwex by DATA

[Kai T. <kti...@go...>]

2011/5/21 Dongsheng Song <don...@gm...>:
> On Thu, May 19, 2011 at 15:28, Dongsheng Song <don...@gm...>
> wrote:
>>
>> 于 2011-5-19 15:14, Ozkan Sezer 写道:
>> > On Thu, May 19, 2011 at 9:51 AM, Dongsheng Song
>> > <don...@gm...> wrote:
>> >> Hi,
>> >>
>> >> There have 69 functions both in libmingwex and 64 bit msvcr90.dll,
>> >> 50 functions both in libmingwex and 32 bit msvcr90.dll, all of them
>> >> should mark by DATA.
>> >>
>> >> PS: I'm using VS 2008 SP1 runtime to generate the .DEF files.
>> >>
>> >>  ChangeLog         |   22 ++++++++
>> >>  lib32/msvcr90.def |  122
>> >> +++++++++++++++++++++++-----------------------
>> >>  lib64/msvcr90.def |  142
>> >> +++++++++++++++++++++++++++---------------------------
>> >>  3 files changed, 154 insertions(+), 132 deletions(-)
>> >>
>>
>
> ping:-)
>
> Without this patch, I can not compile cx-Oracle. Due to the official
> python-2.7 distro use msvcr90.dll,
> then when I compile cx-Oracle, setup.py will link libmsvcr90.a
> automatically, failed on symbols conflict.
>
> With this patch, I can build and test cx-Oracle smoothly.
>
> --
> Dongsheng

AFAICS is the patch for msvcr90 ok. The DATA marking looks right.
Ozkan, what are your concerns here in details?

Regards,
Kai