#287 __strtod: fpi structure missing initializer

closed-fixed
nobody
crt (84)
5
2012-05-02
2012-04-25
Scott Michel
No

SVN revision 4965 (personal nightly build)

Build terminates unexpectedly while compiling the CRT in mingw-w64-crt/gdtoa/strtodnrp.c, after compiling binutils, all-gcc and headers. Looks like an additional field was added to the FPI struct (int_max), which is not initialized in __strtod.

Unclear what the proper resolution ought to be -- the right thing to do looks like adding INT_MAX as the last FPI initializer.

Preprocessed source attached.

Discussion

  • Scott Michel
    Scott Michel
    2012-04-25

    preprocessed strtodonrp.c

     
    Attachments
  • Scott Michel
    Scott Michel
    2012-04-30

     
    Attachments
  • Scott Michel
    Scott Michel
    2012-04-30

    "Int_max" appears to be the proper initializer, based on browsing the source where struct FPI is used.

    Patch attached.

     
  • Kai Tietz
    Kai Tietz
    2012-05-02

    Thanks for reporting this. I noticed that the same issue happens in strtopx and in strtof files, too.
    I am testing a patch for them.

     
  • Kai Tietz
    Kai Tietz
    2012-05-02

    Ok applied to trunk at revision 4970. This patch might be also something for 2.x branch, so I keep it open as pending.

     
  • Kai Tietz
    Kai Tietz
    2012-05-02

    • status: open --> pending-fixed
     
  • Ozkan Sezer
    Ozkan Sezer
    2012-05-02

    Changes applied to stable/v1 and v2. Closing.

     
  • Ozkan Sezer
    Ozkan Sezer
    2012-05-02

    • status: pending-fixed --> closed-fixed