Re: Adding mh-index-ticked-messages to MH-E and refactoring mh-index-new-messages

[Bill W. <wo...@ne...>]

Thanks, Mark.

Mark D. Baushke <md...@gn...> wrote:

> +(defcustom mh-index-ticked-messages-folders t

And mh-index-new-messages-folders should "go away" (although we probably
shouldn't actually nuke the variable until 8.0, but come up with a good
scheme for obsoleting variables and functions).

> -        "[t]hread; [s]earch; [i]ndexed search;\n"
> +        "[n]ew messages; [s]earch; [i]ndexed search;\n"

Good catch. Did you really mean to nuke "[t]hread"? Let's add "': ticked
messages" and "se[q]uenced messages" (unless we come up with something
better).

> +(defun mh-index-sequenced-messages (folders sequence)
>    "Display new messages.
>  All messages from FOLDERS which are in SEQUENCE are displayed.
>  By default the folders specified by `mh-index-new-messages-folders' are
>  searched. With a prefix argument, enter a space-separated list of folders, or
>  nothing to search all folders.
>  
> -Argument SEQUENCE is optional to keep the function compatible with previous
> -releases where the `mh-unseen-seq' was assumed to be the sequence that the
> -function searched for."
> -  (interactive
> -   (if current-prefix-arg
> -       (list (split-string (read-string "Search folder [all]? "))
> -             (mh-read-seq "Search for" nil mh-unseen-seq))
> -     (list mh-index-new-messages-folders mh-unseen-seq)))
> +Argument SEQUENCE defaults to `mh-unseen-seq' and is the sequence that the
> +function searches for in each of the FOLDERS."
> +  (unless folders (setq folders t))
>    (unless sequence (setq sequence mh-unseen-seq))

This function should be interactive (with a "F q" keybinding) also and
*not* provide a default sequence.

> +(defun mh-index-new-messages (folders)
> +  "Display unseen messages.
> +All messages in the `unseen' sequence from FOLDERS are displayed.
> +By default the folders specified by `mh-index-new-messages-folders'
> +are searched. WIth a prefix argument, enter a space-separated list of
                  ^ typo

> +  (interactive
> +   (list (if current-prefix-arg
> +             (split-string (read-string "Folders to search: "))
> +           mh-index-new-messages-folders)))
...
> +(defun mh-index-ticked-messages (folders)
> +  "Display ticked messages.
> +All messages in the `tick' sequence from FOLDERS are displayed.
> +By default the folders specified by `mh-index-ticked-messages-folders'
> +are searched. WIth a prefix argument, enter a space-separated list of
                  ^ typo
> +  (interactive
> +   (list (if current-prefix-arg
> +             (split-string (read-string "Folders to search: "))
> +           mh-index-ticked-messages-folders)))

I wonder if we can refactor these interactive phrases into
mh-index-sequenced-messages? You liked "Folders to search:" better than
"Search folder [all]" ?

--
Bill Wohler <wo...@ne...>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.