#2 Meteorite SIGSEGV on exit (patch attached, fixes wxFileDropTarget bug)

Unstable_(example)
closed
nobody
None
1
2013-02-14
2013-01-13
Fredrik Roubert
No

It's not legal in wxWidgets to set an object derived from wxWindowBase to be its own drop-target, for the wxWindowBase destructor will unconditionally destroy its drop-target (ie. itself). See the implementation of the wxWindowBase destructor:

http://svn.wxwidgets.org/viewvc/wx/wxWidgets/trunk/src/common/wincmn.cpp?view=markup

Because of this, the current implementation of MeteoriteDialog will always crash with a SIGSEGV upon exit. The attached patch solves this by moving the OnDropFiles() method into a separate object.

1 Attachments

Discussion

  • Death Knight®
    Death Knight®
    2013-02-14

    Yes, I remember that I hurry to release it on my birthday. So whole GUI made in some minutes. Thanks for the patch. I added it to svn trunk..

     
  • Death Knight®
    Death Knight®
    2013-02-14

    • status: open --> accepted
     
  • Death Knight®
    Death Knight®
    2013-02-14

    • status: accepted --> closed