[Mesa3d-dev] [ mesa3d-Patches-1015696 ] Eliminate all warnings, fix some possible errors

[SourceForge.net <no...@so...>]

Patches item #1015696, was opened at 2004-08-25 00:32
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300003&aid=1015696&group_id=3

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gregor Anich (blightx0r)
Assigned to: Nobody/Anonymous (nobody)
Summary: Eliminate all warnings, fix some possible errors

Initial Comment:
Hi!

Since we use -Werror where possible for ReactOS I have
eliminated all warnings from the Mesa source when built
with gcc-3.4.1/mingw.
The flags to use are -O2 -Werror -Wall -pedantic -std=c99

Why O2? Because GCC will only with -O2 detect some kind
of situations where it spits out a warning.
Why std=c99? To eliminate the warnings about C89 not
supporting long long and C++ comments.

Most of the warnings were unused arguments. There were
also some violations of the strict aliasing rules where
I have changed the source to avoid the warning (because
it does not break these rules as long as sizeof (int)
== sizeof (float) as far as i can tell). There were
also some conversions between pointer/function object
types.

Finally at some places there were comparisons of
signed/unsigned and checks for unsigned values >= 0
which will always be TRUE - this came from unsigned
enums (which GCC uses by default unless you put a
negative element into the enum) so i put "Xxx_INVALID =
-1" into 2 enums (OpCode in main/dlist.c and fp_opcode
in shader/nvfragprog.h)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300003&aid=1015696&group_id=3