Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#11 file releases contain windows garbage

closed-fixed
Mark Vejvoda
None
5
2011-01-20
2010-10-12
bojo42
No

in the course of updating the ubuntu packages i noticed that the file releases contain windows specific stuff:

- megaglest-source-3.3.7.tar.bz2: a lot of files have Windows end-of-line characters that make patches unapplyable
- megaglest-data-3.3.7.7z: does have thumbs.db files:
techs/megapack/factions/indian/units/firegolem/images/thumbs.db
techs/megapack/factions/indian/units/horseman/images/thumbs.db
techs/megapack/factions/indian/units/shaman/images/thumbs.db
techs/megapack/factions/norsemen/units/thor/images/thumbs.db
techs/megapack/factions/norsemen/units/valhalla/images/thumbs.db
techs/megapack/factions/norsemen/upgrades/advanced_iron/images/thumbs.db

maybe you could use a shell script for the file releases that check on that. thx

Discussion

  • bojo42
    bojo42
    2010-10-12

    here is what i use for that on GNU/Linux:

    find . * -exec file {} \; | grep CRLF

    only files with CRLF will be modified
    find . * -type f -exec fromdos {} \;

    find . -name "thumbs.db" -type d -exec rm -rf {} \;

    you could also strip the SVN dir:
    find . -name ".svn" -type d -exec rm -rf {} \;

     
  • bojo42
    bojo42
    2010-10-21

    great to see that 3.3.7.2 files are free of .svn and thumbs.db.

    but i have to correct myself about using fromdos, as with:

    find . * -type f -exec fromdos {} \;

    non CRLF files like binaries MAY BE MODIFIED!!! so it's better to use:

    find . -exec file {} \; | grep CRLF | cut -d: -f1 | xargs fromdos -v

    this assumes that the filenames don't contain colons and only files that have CRLF will be touched.

     
  • M. Naumann
    M. Naumann
    2011-01-11

    Thanks for the hint. thumbs.db are now removed off the repository (r1508).
    Line endings still need to be converted, this should be done shortly before (or after) next release.

     
  • Mark Vejvoda
    Mark Vejvoda
    2011-01-20

    • assigned_to: nobody --> mvejvoda
    • status: open --> closed-fixed
     
  • Mark Vejvoda
    Mark Vejvoda
    2011-01-20

    ran fromdos on text files to have consistent line endings as requested and checked into svn