Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#16 Support for configurable icon

open
Jin
None
5
2010-04-06
2010-01-23
Pete Fordham
No

Adds support for an <icon> tag in config.xml. It's a bit hacky but it does work.

Discussion

  • Pete Fordham
    Pete Fordham
    2010-01-23

     
    Attachments
  • Jin
    Jin
    2010-04-06

    I see some WMA stuff also in your diff?

    Anyway.. the problem with the icon is, that specific sizes must be used (UPnP defines that), and as long as we can not fully check the sizes I am somewhat hesitant of adding this option.

    Maybe we could limit the icon type to JPEG for now, we do have a jpeg resolution extractor function which we could use to do the checking at startup.

     
  • Jin
    Jin
    2010-04-06

    • assigned_to: nobody --> jin_eld
     
  • Pete Fordham
    Pete Fordham
    2010-04-06

    The WMA stuff for for getting tag info from WMA files using taglib. I thought you'd already picked up those changes anyway, haven't really been following the status of stuff. It was probably included in this diff by accident.

    I use imagemagic to scale all the input image types to the correct set of sizes at startup automatically. This has been working fine for me with PNG on my PS3 since I first submitted this change set.