#802 Likely infinite loop when parsing a AAC ELD file

Crash
closed-fixed
None
9
2013-12-17
2013-11-27
No

tested on 0.7.64 and 0.7.65.
I used mediainfo CLI on a directory which contains some audio/video files but also some images. Images should not be handled by mediainfo but one Macintosh PCT file seems to be recognized as AAC ELD audio file. In fact, mediainfo never returns but loops indefinitely.
Attached is a patch that solve the issue. I don't know if it's the right fix because I don't have any AAC-ELD file to test it.

here is the result for this image, I don't know why it is recognized as audio file :

General
Complete name : /tmp/72ae7e2f1d5d7c7d4bad4ef63283cbdc.pct
Format : LATM
File size : 102 KiB

Audio
Format : ER AAC ELD
Channel count : 2 channels
Channel positions : Front: L R
Sampling rate : 0 Hz

1 Attachments

Discussion

  • Images should not be handled by mediainfo

    MediaInfo has a basic support of images, it is also the goal (but it is definitely less important as video and audio)

    I don't know if it's the right fix

    I'll confirm with the specs.

    I don't know why it is recognized as audio file :

    Definitely a false positive. Is it possible to get the file? by private email if you don't want to spread it, so I try to correct it and I can put it in my regression tests.

     
    • status: open --> open-accepted
    • assigned_to: Jerome Martinez
    • Group: Usability --> Crash
    • Priority: 5 --> 9
     
  • Stupid loop bug (not made by me :-D, but it is corrected now)
    Patch (slightly adapted from yours)
    For the false positive detection, I improved a bit the parser, Patch in order not to have anymore this false positive.

    But for the other one (your link), I give up for now with free support, because I should implement a deeper MPEG Audio analysis in order to see it does not decode well, and it is too much time. I keep the file for later when I have some free time.

     
    • status: open-accepted --> closed-fixed