Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#68 tests.zoom.py suite fails to run

SVN
open
Ark
None
5
2014-04-06
2014-04-06
firesock
No

$ python -m unittest -v test.zoom
Traceback (most recent call last):
File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/lib64/python2.7/unittest/main.py", line 12, in <module>
main(module=None)
File "/usr/lib64/python2.7/unittest/main.py", line 94, in init
self.parseArgs(argv)
File "/usr/lib64/python2.7/unittest/main.py", line 149, in parseArgs
self.createTests()
File "/usr/lib64/python2.7/unittest/main.py", line 158, in createTests
self.module)
File "/usr/lib64/python2.7/unittest/loader.py", line 128, in loadTestsFromNames
suites = [self.loadTestsFromName(name, module) for name in names]
File "/usr/lib64/python2.7/unittest/loader.py", line 100, in loadTestsFromName
parent, obj = obj, getattr(obj, part)
AttributeError: 'module' object has no attribute 'zoom'

when trying to run tests. Also shows up as via setuptools test.

Seems to be caused by imports in tests.zoom, from mcomix.zoom, some of the classes no longer exist.

Discussion

  • Oddegamra
    Oddegamra
    2014-04-06

    Yeah, most, if not all of the code that was originally being tested has been replaced. It might be appropriate to either kill the test or rewrite it for the new zooming code.

     
  • Oddegamra
    Oddegamra
    2014-04-06

    • assigned_to: Ark
     
  • Ark
    Ark
    2014-04-06

    Sorry, my bad. As Oddegamra already pointed out, especially the tests for mcomix/zoom.py are outdated. The new mcomix/zoom.py absolutely doesn't look the way it used to. Admittedly, I don't have enough time to keep the tests updated, therefore I consider deleting test/zoom.py.

    @Awad Mackie: Oddegamra just committed code that actually comes from you. Are you interested in this project, i.e. coding on a (more or less) regular basis? We could always use a helping hand or two. :-) Don't worry, it's not like you will be forced to write only tests. Actually, there is a lot of work to do beyond testing. If you are interested, please contact Oddegamra for further information.

     
  • firesock
    firesock
    2014-04-06

    The other 2 test suites do run fine though, thought you might like to just scrap most of this one.

    @Ark: Sorry, but I don't think I have the time for regular contributions right now.