#48 Fix recent laplace() breakage

closed
nobody
None
5
2012-11-12
2012-11-11
Kris Katterjohn
No

It seems that commit ad589ae1685225c96fce05292e2304f4b0afc265 on October 20th broke laplace() for situations requiring the use of the hackit function in laplac.lisp. The commit involves changing the scope of the variable parm.

There were actually two problems. The first was the hackit no longer had access to parm, so this happened:

(%i1) laplace(sin(t)/t,t,s);
Maxima encountered a Lisp error:

HACKIT: variable PARM has no value

Then it turned out that the call to mydefint in lapexpt wasn't passing the correct number of arguments (which changed along with parm).

I've attached a patch fixing this issue for me. This makes hackit take a parm parameter and fixes the call to mydefint (notice that this particular call now passes parm for the parm parameter as well as passing parm for the limit of integration--I think this is consistent). This patch also removes a now-superfluous let binding of parm in hackit. Now:

(%i1) laplace(sin(t)/t,t,s);
%pi
(%o1) --- - atan(s)
2

[That's pi/2-atan(s) in case the alignment messes up]

I didn't notice any other problems with laplace(). Let me know what you think!

Discussion

  • Patch to fix laplace()

     
    Attachments
    • status: open --> closed