Re: [mantisbt-dev] bug 8044

[Colin P. <col...@bu...>]

We are checking against a particular value, META_FILTER_NONE in the 
value chosen by the user that filter. It's what the dropdown list return 
if the user ask to filter bugs that have an empty field.

This test is not the only one comparing META_FILTER_NONE to 
$t_filter_member in the file, but it's the only one using a === instead 
of a ==.

There is still a "bug" as you can't search for the value -2, either in 
string or integer value, because META_FILTER_NONE is defined as follow :

core/constant_inc.php:  define( 'META_FILTER_NONE',     -2  );

but it corrects a feature that is, in my opinion, much more important, 
the empty custom fields, and by the way, the bug is already existing 
(try adding a custom field, fill a bug with the value -2 for this field 
and try to search for it).

When you add a field to a project, you sometimes want to fill it for 
every bug. This is the best way to do it, and without this patch, it 
doesn't work.

The remaining bug could easily be corrected by not using 
META_FILTER_NONE but another constant defined to the empty string.

Colin Pitrat (Bull Services Telco)
Bull,  Architect of an Open World (TM)
Tél : +33 (0)  1 30 80 72 93
www.bull.com


> -------- Message original --------
> De: Glenn Henshaw <thr...@lo...>
> Pour: developer discussions <man...@li...>
> > Date: 03/07/2007 3:20:29 AM +0200
> Objet: [mantisbt-dev] bug 8044
>
>    I looked at the patch.
> 
>    I'm concerned that the first line (changing '===' to '==') may be  
> problematic. Filters can have either text or numeric values. When  
> comparing to a number, a string is converted to 0.
> 
>    Could you check this operation before committing?
> 
>     ... Glenn
> 
> 
> On 2-Jul-07, at 11:38 AM, Colin Pitrat wrote:
> 
>> Nice ! So if you have time, could you take a look at this bug, and  
>> the second patch that I posted ? http://www.mantisbt.org/bugs/ 
>> view.php?id=7809
>>
>> Thanks ;)
>>
>> Colin Pitrat (Bull Services Telco)
>> Bull,  Architect of an Open World (TM)
>> Tél : +33 (0)  1 30 80 72 93
>> www.bull.com
>>
>>
>>> -------- Message original --------
>>> De: "Gianluca Sforna" <gi...@gm...>
>>> Pour: col...@bu..., "developer discussions" <mantisbt- 
>>> de...@li...>
>>>> Date: 02/07/2007 5:28:56 PM +0200
>>> Objet: [mantisbt-dev] bug 8044
>>>
>>> On 7/2/07, Colin Pitrat <col...@bu...> wrote:
>>>> This is fine with me except that I think there is a small  
>>>> indentation
>>>> problem on the closing brace of the if concerning "users above
>>>> delete_bugnote_threshold".
>>>>
>>>> However, there's a lot of patches of small annoying bugs that are
>>>> waiting to be committed for quite a long time. Let's hope yours  
>>>> will be
>>>> luckier !
>>> It should, as I was given commit access recently... ;)
>>> thanks for having a look<colin.pitrat.vcf>
>> ---------------------------------------------------------------------- 
>> ---
>> This SF.net email is sponsored by DB2 Express
>> Download DB2 Express C - the FREE version of DB2 express and take
>> control of your XML. No limits. Just data. Click to get it now.
>> http://sourceforge.net/powerbar/db2/ 
>> _______________________________________________
>> mantisbt-dev mailing list
>> man...@li...
>> https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
>