Re: [Mantisbt-dev] LDAP Patches

[Robert F. <rf...@mo...>]

Hi James,
Comments on Patch below...  On the whole looks good, but I only went
through the patch by sight, and haven't really looked at it in the
larger scheme of things:)

Regards,
Robert Foster
Mountain Visions P/L
Australia
rf...@mo...

On Fri, 2003-10-24 at 03:50, JAmes Atwill wrote:
> Hello,
> 
> I'm currently in the process of integrating Mantis with our local LDAP
> directory.
> 
> The attached diff file makes the following changes:
> 
> - Create User: UI won't ask for password if using LDAP, won't ask for
> email address if use_ldap_email is on.  The current patch
> puts 'using_ldapNNNNN' (where N is a series of random numbers) for a
> password in the database.
> 
> - Manage User: Will lookup the users email address in the LDAP directory
> if use_ldap_email.
> 
Looks good so far to me, need to tidy up on the formatting to bring it
in line with the rest of the code (spaces around variables and braces,
for example).  I'm sure that Jeroen will have more to say than I on
this. :)
> - Core/LDAP: uses the 'mail' attribute, not the 'email' attribute 
> 
Whoops... Quite right. This one must have gotten past me when I wrote it
initially... good catch :) - Jeroen - is it possible to get this into
the 0.18 release?

> These patches (against HEAD) presume the administrator has pre-made the
> user in the LDAP directory using an external tool (such as phpldapadmin)
> and simply wants to use the common attributes (email, password, name,
> etc) for Mantis.   I believe this is likely the most common scenario for
> most people. 
> 
> Comments?
> 
> 	JAmes
> 
> 
> 
> :::