From: GitHub <no...@gi...> - 2014-07-10 07:38:28
|
Branch: refs/heads/master Home: https://github.com/mantisbt/mantisbt Commit: b7ebffd620a57c150577af24bf6d46e9c6d091a4 https://github.com/mantisbt/mantisbt/commit/b7ebffd620a57c150577af24bf6d46e9c6d091a4 Author: Damien Regad <dr...@ma...> Date: 2014-07-07 (Mon, 07 Jul 2014) Changed paths: M core/constant_inc.php M library/README.libs M library/adodb Log Message: ----------- Update ADOdb to 5.19 Commit: 84d21a61f61335d9d66a8ecdac88bcf5e6b16590 https://github.com/mantisbt/mantisbt/commit/84d21a61f61335d9d66a8ecdac88bcf5e6b16590 Author: Damien Regad <dr...@ma...> Date: 2014-07-07 (Mon, 07 Jul 2014) Changed paths: M core/database_api.php Log Message: ----------- oci8 no longer needs special fetch mode with ADOdb 5.19 Fixes #15426 Commit: f9c2aec0718f0cac2e6b9f626e2a3661b2303c2b https://github.com/mantisbt/mantisbt/commit/f9c2aec0718f0cac2e6b9f626e2a3661b2303c2b Author: Damien Regad <dr...@ma...> Date: 2014-07-07 (Mon, 07 Jul 2014) Changed paths: M core/database_api.php Log Message: ----------- Use ADODB-specific constant instead of 'false' Commit: 83e1cfde28459f74fd34aa8a2e233ccd7c6385dd https://github.com/mantisbt/mantisbt/commit/83e1cfde28459f74fd34aa8a2e233ccd7c6385dd Author: Damien Regad <dr...@ma...> Date: 2014-07-08 (Tue, 08 Jul 2014) Changed paths: M core/database_api.php Log Message: ----------- Coding guidelines Commit: fbf016c3b497a7b223751fd4cc537904c4810b58 https://github.com/mantisbt/mantisbt/commit/fbf016c3b497a7b223751fd4cc537904c4810b58 Author: Damien Regad <dr...@ma...> Date: 2014-07-08 (Tue, 08 Jul 2014) Changed paths: M core/database_api.php Log Message: ----------- Fix db_query_bound() to work with ADOdb::Execute() In ADOdb v5.19 the Execute() method was modified to perform a strict type check on the $inputarr parameter. Since that param defaults to 'false', database errors are triggered when the method receives 'null' and there are no parameters to the query being executed. Since db_query_bound() $p_arr_parms defaults to null, the problem occurs almost everywhere. To fix this, we can either: 1. set $p_arr_parms to array() when it is null 2. defaut $p_arr_parms to array() The 2nd option would cause errors with db_query_bound($sql, null) calls, so we implement the first one as it offers better backwards compatibility. Function can be called like this (the first 3 methods being equivalent): - db_query_bound($sql) - db_query_bound($sql, null) - db_query_bound($sql, array()) - db_query_bound($sql, array(1,2)) Commit: c726ff7b8449d76763919e65c1d3dbbcd63e7ded https://github.com/mantisbt/mantisbt/commit/c726ff7b8449d76763919e65c1d3dbbcd63e7ded Author: Damien Regad <dr...@ma...> Date: 2014-07-08 (Tue, 08 Jul 2014) Changed paths: M core/project_hierarchy_api.php M core/summary_api.php M core/user_api.php M manage_user_page.php Log Message: ----------- Call db_query_bound() with array() instead of null This is not strictly necessary right now, but replacing known occurences avoids future refactoring should we decide to change the default value for $p_arr_parms to array() later on. Commit: a2b23b3bc04b41c7925ea204a4b2dbd2b028b159 https://github.com/mantisbt/mantisbt/commit/a2b23b3bc04b41c7925ea204a4b2dbd2b028b159 Author: Damien Regad <dr...@ma...> Date: 2014-07-09 (Wed, 09 Jul 2014) Changed paths: M core/constant_inc.php M core/database_api.php M core/project_hierarchy_api.php M core/summary_api.php M core/user_api.php M library/README.libs M library/adodb M manage_user_page.php Log Message: ----------- Update ADOdb to 5.19 - update the submodule - back to ADODB_FETCH_ASSOC for oci8 - fix db_query_bound() $p_arr_parms null default issue Fixes pull request https://github.com/mantisbt/mantisbt/pull/181 Commit: af6c6e559b9b92d83c93fb5e6633e9c249da1f77 https://github.com/mantisbt/mantisbt/commit/af6c6e559b9b92d83c93fb5e6633e9c249da1f77 Author: Damien Regad <dr...@ma...> Date: 2014-07-10 (Thu, 10 Jul 2014) Changed paths: M core/event_api.php Log Message: ----------- Fix E_RECOVERABLE_ERROR in event_api Regression introduced by 5458f7020999317b35f403fa2a0e477d6182ec12. Commit: 2fbec66b13b89702af6f40a20ac51bc0b9c6c1eb https://github.com/mantisbt/mantisbt/commit/2fbec66b13b89702af6f40a20ac51bc0b9c6c1eb Author: Damien Regad <dr...@ma...> Date: 2014-07-10 (Thu, 10 Jul 2014) Changed paths: M core/error_api.php Log Message: ----------- NOTICE errors now display caller and line number Compare: https://github.com/mantisbt/mantisbt/compare/64af35e47040...2fbec66b13b8 |