From: Paul R. <pa...@ma...> - 2014-04-15 13:35:19
|
On Tue, Apr 15, 2014 at 2:12 PM, Damien Regad <dr...@ma...> wrote: > On 09.04.2014 23:31, P Richards wrote: > > Attached is my start on documenting the new database layer. > > Had a quick look (no time to go into details), > > 1. what's the basis for the versions on the 1st table ? just what you > tested against ? These are all quite recent versions, and might be > considered as recommended - we should list the minimum supported version > Versions I'm testing against so far. I'll probably spend some time to run unit tests against a few older versions once those versions are stable. we should run unit tests against: mariadb (MySQL fork), and percona, and MySQL for instance, and go back a few versions. and also a few of the older pgsql versions. With MSSQL, 2008, 2012 and 2014 are the main versions > > 2. What do you use to generate the PDF ? I would like to avoid having > several toolchains for documentation - at the moment we use publican (XML). > > Ultimately this should be merged into the Developers' Guide. > The file at the moment is a markdown file - mainly as github/gitlab support this, and you can get graphical editors. > > > The version field is expected to be an integer format > > 3. Shouldn't it be a string ? '9.3.4' is not an integer... > > 4. Data types > > - what's the point of 'X' type, vs C(N) ? > - missing Oracle types. > > C(N) in adodb defines a character field of up to 255 charactesr X in adodb is basically C(4000) Paul |