[mantisbt-commits] [mantisbt/mantisbt] 123c2c: Fix system warning in html_status_legend() with cu...

[GitHub <no...@gi...>]

  Branch: refs/heads/master-1.2.x
  Home:   https://github.com/mantisbt/mantisbt
  Commit: 123c2c89a58b2bca93e7bf4ff37189a9acad571d
      https://github.com/mantisbt/mantisbt/commit/123c2c89a58b2bca93e7bf4ff37189a9acad571d
  Author: Damien Regad <dam...@me...>
  Date:   2012-07-03 (Tue, 03 Jul 2012)

  Changed paths:
    M core/html_api.php

  Log Message:
  -----------
  Fix system warning in html_status_legend() with custom status

When using custom status for which no language strings are defined,
html_status_legend() triggered system warnings.

MantisBT now displays the custom status' name as defined in the enum,
in case there is no available translation string.

Fixes #14446


  Commit: 91a99d97d713a634e8727edc6bd8f7d2f9c449c0
      https://github.com/mantisbt/mantisbt/commit/91a99d97d713a634e8727edc6bd8f7d2f9c449c0
  Author: Damien Regad <dam...@me...>
  Date:   2012-07-03 (Tue, 03 Jul 2012)

  Changed paths:
    M bug_actiongroup.php
    M bug_update.php
    M core/bug_api.php

  Log Message:
  -----------
  Add param to bug_resolve() to allow "resolution" to custom status

Function bug_resolve() sets the status to bug_resolved_status_threshold.
This behavior is fine with MantisBT's default status enum, but is
causing issues when using a custom target status that is
>= $g_bug_resolved_status_threshold & < $g_bug_closed_status_threshold.

In this case, when changing status using the button on view.php, the
target status selected by the user is overriden by the value of
bug_resolved_status_threshold, resulting in incorrect behavior. The only
way to effectively reach the custom state is by editing the issue.

To address this, a new optional parameter $p_status is added to
bug_resolve(). To make the function call more logical, the signature was
modified: new parameter inserted in 3rd position after $p_resolution.

The function's phpdoc header has been completed.

Fixes #14443


  Commit: f9b9e2fc43568051929cb181ab5f164e7d028aed
      https://github.com/mantisbt/mantisbt/commit/f9b9e2fc43568051929cb181ab5f164e7d028aed
  Author: Damien Regad <dam...@me...>
  Date:   2012-07-03 (Tue, 03 Jul 2012)

  Changed paths:
    M bug_update.php

  Log Message:
  -----------
  Code cleanup in bug_update.php

Fixes whitespace, code alignment, typos in comments, long lines


Compare: https://github.com/mantisbt/mantisbt/compare/8d35e57a9977...f9b9e2fc4356