[mantisbt-commits] mantisbt.git branch, master-1.2.x, updated. release-1.2.0rc2-87-g2730f01

[<gi...@ma...>]

The branch, master-1.2.x has been updated
       via  2730f0106276cdae209959cc6b9a38a4ed2b7d01 (commit)
      from  0eb89e062052f5b57c375006774482b77ddc9d63 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2730f0106276cdae209959cc6b9a38a4ed2b7d01
Author: David Hicks <hic...@op...>
Date:   Sun Nov 22 23:37:25 2009 +1100

    Fix #11026: Fix XSS bug in view_filters_page.php
    
    Fix a parsing/validation error whereby a target_field input of the form
    "status[]<script>bad_code();</script>" would be printed directly to
    HTML, thus leading to a XSS vulnerability.

-----------------------------------------------------------------------

Summary of changes:
 view_filters_page.php |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------

commit 2730f0106276cdae209959cc6b9a38a4ed2b7d01
Author: David Hicks <hic...@op...>
Date:   Sun Nov 22 23:37:25 2009 +1100

    Fix #11026: Fix XSS bug in view_filters_page.php
    
    Fix a parsing/validation error whereby a target_field input of the form
    "status[]<script>bad_code();</script>" would be printed directly to
    HTML, thus leading to a XSS vulnerability.

diff --git a/view_filters_page.php b/view_filters_page.php
index a50cfe9..c989423 100644
--- a/view_filters_page.php
+++ b/view_filters_page.php
@@ -41,8 +41,8 @@
 	html_page_top();
 
 	$t_filter = filter_get_default();
-	$t_target_field = gpc_get_string( 'target_field', '' );
-	if ( !isset( $t_filter[ rtrim( $t_target_field, '[]' ) ] ) ) {
+	$t_target_field = rtrim( gpc_get_string( 'target_field', '' ), '[]');
+	if ( !isset( $t_filter[ $t_target_field ] ) ) {
 		$t_target_field = '';
 	}
 

-----------------------------------------------------------------------


--
Mantis Bug Tracker