From: Paul Richards <paul@ma...> - 2009-05-17 22:40:08
----- "Gianluca Sforna" <giallu@...> wrote:
> On Mon, May 4, 2009 at 6:33 PM, Paul Richards <paul@...>
> > For 3rd party libraries, we're going to have to do something
> > For PHPMailer class, it's in a file called class.phpmailer.php
> (Note: lowercase)
> > For RSSBuilder class, it's in a file called class.RSSBuilder.inc.php
> (note addition of .inc. and mixed case)
> > For nusoap_client class, it's in a file called class.soapclient.php
> (note name doesn't even match).
> > Yes, we could move all libraries into an include path /library, but
> we'd still need the switch statement, unless we start renaming
> classes/filenames of libraries, which i'm guessing we dont want to
> Yes, surely we don't want to rename 3rd party stuff, but I don't see
> adding a switch case in the autoload function to treat each class
> as a special one a really good thing to do.
> I think all 3rd party stuff should be loaded explicitly, while our
> classes should follow the same pattern to offer autoload
> with a single/simpler logic.
> And since I really hate to talk about stuff without doing any actual
> work to back my points, I took some time to start the move, as you
> see from my latest push.
> IMHO this is the first step toward a better organization of the
> codebase, so feel free to have a look and point out stuff I'd
> eventually broke.
> Best regards
I've redone the autoload stuff I added in a simpler way outside of the __autoload file to keep that clean.
Whilst we are in the process of 'breaking' things and we might be unstable for a few days whilst we move stuff around, I'm taking the opportunity to push the dates changes i'd been working on.
daryn/myself have tested the db changes, and dhx has given an initial review separately to that - whilst there's still some things that need tidying (e.g. I don't like where I'm currently setting the timezone) - I think that's probably easier to fix with everything in git (personally, I'm finding that I'm moving to working on altering how we handle user preferences (as timezone is a preference) as opposed to working on fixing issues with the dates changes themselves)
Anyway, this is just a warning to anyone that regularly updates to GIT TRUNK that it's probably advisable to avoid updating for a few days :)