I've created a pull request to review the change:
https://github.com/mantisbt/mantisbt/pull/95

There is a factory class that abstracted away some of the differences between PHP SOAP extension and Nusoap.  I left this in place for now, since it will require changes all over the place.  I'm thinking we do a first checkin to remove the nusoap dependency, then we can follow up with another as needed to remove this class.


On Tue, Oct 1, 2013 at 2:02 AM, Robert Munteanu <robert.munteanu@gmail.com> wrote:
On Tue, Oct 1, 2013 at 7:32 AM, Victor Boctor <vboctor@gmail.com> wrote:
> I've noticed that we still have nusoap in master.  Do we have a reason to
> continue using nusoap?  Or should we drop it in the v1.3?

No, I think we should drop it for 1.3 . Roland has mentioned that the
minimal required PHP version is safe to use with the SOAP extension.

I also think the bugs due to the conversion have been fixed in 1.2.x. already.

>
> I've also noticed that the nusoap folder has some readme / index.html to
> block browsing directory.  In the case of the core folder, we have an
> .htaccess.  We don't have the same for the library/ folder.  Should we also
> protect library/ the same way we protected core/?

+1.

Robert

>
> [The questions here apply independent of the base branch for v1.3]
>
> Thanks,
> -Victor



--
http://robert.muntea.nu/