I think we should hold off on using submodules at this stage:

Apart from the fact i've still got concerns about adding submodules for adodb when we are looking at replacing it - There's a number of articles on the internet stating submodules are a bad idea - for example http://somethingsinistral.net/blog/git-submodules-are-probably-not-the-answer/ 

On other things I've done, we've always ended up avoiding submodules for similar reasons to the above.

Whilst i've not used it (as we used mercurial instead), I've heard of people using git subtree to keep the code in the repository whilst doing similar to the submodule approach. At the moment, if there's a commit to a submodule, it means that people can get a different version of 'mantis' checked out, and if you only follow mantis commits, you could miss the change.

+1 to making master default in github



On Tue, Oct 8, 2013 at 11:21 PM, Damien Regad <dregad@mantisbt.org> wrote:
Hi all,

Except for a few comments from Victor, I have not received any feedback
on my '13x' branch, so I assume everybody's fine with it (or doesn't
care ?).

I will therefore proceed with merging the changes into master soon, i.e.
after making sure that the build scripts can cope with the git submodules.

If you're not happy with this, speak now or forever hold your peace...

To minimize headaches and problems with porting changes to/from 1.2.x
branch, I will also add the submodules for ADOdb and phpMailer there. I
invite you to familiarize yourself with their use, and read the wiki
page I wrote:

http://www.mantisbt.org/wiki/doku.php/mantisbt:git_submodules

At the same time, I will also make 'master' the default branch at Github.

Damien



------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
mantisbt-dev mailing list
mantisbt-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev