Well, the DISTINCT should currently be there to ensure we don't get duplicate bug id's from the filter api.

In any case, we don't support pgsql or mssql in the 1.2 branches as they are known broken. The db api changes in 2.x branch should bring mssql support, so we can just make a note not to port this commit to the 2.x branch.

In terms of testing, due to the fact that 1.2 doesn't support mssql, that's not really possible.

Paul



On Sat, Aug 31, 2013 at 1:26 AM, Damien Regad <dregad@mantisbt.org> wrote:
On 2013-08-27 09:16, Gianluca Sforna wrote:
 > Daryn reworked a lot of that area so it could be in better shape by
 > now.
 >
 > That said, removing the distinct clause and waiting for the fallout
 > (if any) could be a viable option to move forward

Thanks for the feedback Gianluca. To avoid regression I pushed a more
conservative solution in 1.2 branch, and removed the DISTINCT in master
branch.

On 2013-08-31 01:23, Paul Richards wrote:
 > Did you test removing the DISTINCT line on MSSQL?

No, I'm on Linux, don't have access to MSSQL. Would *you* be able to test ?

 > IIRC, I think it was that DB engine where we've needed to add it
 > before.

AFAICT, this section of the filter API was heavily modified by Daryn for
fix of #9104 [1], so going backwards from there is not easy but I think
the previous change is [2] and if I keep moving it goes all the way back
to the very creation of filter_api.php by Julian Fitzell in 2002 [3]

 > We probably shouldn't remove it unless we've tested it on all the DB
 > engines we support.

+1 on principle, but given the complexity of filter api and thousands of
possible test scenarios, unless we know the reasons and have a test case
for making the original change, it's a huge effort.

I did perform limited testing on MySQL and PostgreSQL.

D


[1] https://github.com/mantisbt/mantisbt/commit/a6fc0c8f#L0R1765
[2] https://github.com/mantisbt/mantisbt/commit/5e7619f7#L0R1315
[3] https://github.com/mantisbt/mantisbt/commit/5b33d49d#L1R175


------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
mantisbt-dev mailing list
mantisbt-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev