Using example.com as the domain for the RSS author was by design in order not to disclose the author's (e.g. reporter's) email.  I wonder if we should keep the old behaviour / make it configurable / new behaviour.

On Mon, Dec 29, 2008 at 4:46 PM, <git@mantisbt.org> wrote:
The branch, master has been updated
      via  17b4e5497245ea6a9dd8c666a14d91fd5e51132f (commit)
      via  b70c4da7457e8a336407e2c115509184f6a570f6 (commit)
      via  063ef750e263a019c34167a6c8e55c840daaa3f0 (commit)
      via  85916e72cd89052bc1157d7f0bb5ca98ab06dd96 (commit)
     from  816d4b2a9fc942682a9d24d88cf2c62d0cbd389b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 17b4e5497245ea6a9dd8c666a14d91fd5e51132f
Author: Gianluca Sforna <giallu@gmail.com>
Date:   Tue Dec 30 01:39:48 2008 +0100

   Fix dates shown on feed

commit b70c4da7457e8a336407e2c115509184f6a570f6
Author: Gianluca Sforna <giallu@gmail.com>
Date:   Tue Dec 30 00:53:13 2008 +0100

   Fix feeds broken by the recent RSSbuilder update

commit 063ef750e263a019c34167a6c8e55c840daaa3f0
Author: Gianluca Sforna <giallu@gmail.com>
Date:   Mon Dec 29 23:43:21 2008 +0100

   Fix 6309: RSS Author Email Tag always shows @example.com

commit 85916e72cd89052bc1157d7f0bb5ca98ab06dd96
Author: Gianluca Sforna <giallu@gmail.com>
Date:   Mon Dec 29 23:42:46 2008 +0100

   Improve description for user_get_name()

-----------------------------------------------------------------------

Summary of changes:
 core/user_api.php |    2 +-
 issues_rss.php    |    6 +++---
 news_rss.php      |   12 ++++--------
 3 files changed, 8 insertions(+), 12 deletions(-)

-----------------------------------------------------------------------

commit 17b4e5497245ea6a9dd8c666a14d91fd5e51132f
Author: Gianluca Sforna <giallu@gmail.com>
Date:   Tue Dec 30 01:39:48 2008 +0100

   Fix dates shown on feed

diff --git a/issues_rss.php b/issues_rss.php
index 477d854..6063c0f 100644
--- a/issues_rss.php
+++ b/issues_rss.php
@@ -187,7 +187,7 @@
               $subject = string_rss_links( category_full_name( $t_bug->category_id, false ) );

               # optional DC value
-               $date = date( 'Y-m-d\TH:i:sO', $t_bug->last_updated );
+               $date = $t_bug->last_updated;

               # author of item
               $author = string_rss_links( user_get_name( $t_bug->reporter_id ) );
diff --git a/news_rss.php b/news_rss.php
index e7135e0..d92abf8 100644
--- a/news_rss.php
+++ b/news_rss.php
@@ -128,7 +128,6 @@

               $v_headline     = string_rss_links( $v_headline );
               $v_body         = string_rss_links( $v_body );
-               $v_date_posted  = date( 'Y-m-d\TH:i:sO', $v_date_posted );

               $about = $link = config_get( 'path' ) . "news_view_page.php?news_id=$v_id";
               $title = $v_headline;

commit b70c4da7457e8a336407e2c115509184f6a570f6
Author: Gianluca Sforna <giallu@gmail.com>
Date:   Tue Dec 30 00:53:13 2008 +0100

   Fix feeds broken by the recent RSSbuilder update

diff --git a/issues_rss.php b/issues_rss.php
index 8282207..477d854 100644
--- a/issues_rss.php
+++ b/issues_rss.php
@@ -36,7 +36,7 @@

       $t_core_path = config_get( 'core_path' );

-       require_once( $t_core_path . 'class.RSSBuilder.inc.php' );
+       require_once( $t_core_path . 'rssbuilder/class.RSSBuilder.inc.php' );
       require_once( $t_core_path . 'user_api.php' );
       require_once( $t_core_path . 'filter_api.php' );
       require_once( $t_core_path . 'rss_api.php' );
@@ -207,7 +207,7 @@
               # optional mod_im value for dispaying a different pic for every item
               $image = '';

-               $rssfile->addItem( $about, $title, $link, $description, $subject, $date,
+               $rssfile->addRSSItem( $about, $title, $link, $description, $subject, $date,
                                                       $author, $comments, $image );
       }

diff --git a/news_rss.php b/news_rss.php
index e67e5ed..e7135e0 100644
--- a/news_rss.php
+++ b/news_rss.php
@@ -27,7 +27,7 @@

       $t_core_path = config_get( 'core_path' );

-       require_once( $t_core_path . 'class.RSSBuilder.inc.php' );
+       require_once( $t_core_path . 'rssbuilder/class.RSSBuilder.inc.php' );
       require_once( $t_core_path . 'news_api.php' );
       require_once( $t_core_path . 'project_api.php' );
       require_once( $t_core_path . 'print_api.php' );
@@ -155,7 +155,7 @@
               # optional mod_im value for dispaying a different pic for every item
               $image = '';

-               $rssfile->addItem(      $about, $title, $link, $description, $subject, $date,
+               $rssfile->addRSSItem( $about, $title, $link, $description, $subject, $date,
                                       $author, $comments, $image);
       }


commit 063ef750e263a019c34167a6c8e55c840daaa3f0
Author: Gianluca Sforna <giallu@gmail.com>
Date:   Mon Dec 29 23:43:21 2008 +0100

   Fix 6309: RSS Author Email Tag always shows @example.com

diff --git a/news_rss.php b/news_rss.php
index 64c0d0e..e67e5ed 100644
--- a/news_rss.php
+++ b/news_rss.php
@@ -144,13 +144,10 @@
               $author = string_rss_links( user_get_name( $v_poster_id ) );
               if ( access_has_global_level( config_get( 'show_user_email_threshold' ) ) ) {
                       $t_author_email = user_get_field( $v_poster_id, 'email' );
-                       if ( is_blank( $t_author_email ) ) {
-                               $t_author_email = $author . '@example.com';
+                       if ( ! is_blank( $t_author_email ) ) {
+                               $author .= ' &lt;' . $t_author_email . '&gt;';
                       }
-               } else {
-                       $t_author_email = $author . '@example.com';
               }
-               $author .= ' &lt;' . $t_author_email . '&gt;';

               # $comments = 'http://www.example.com/sometext.php?somevariable=somevalue&comments=1';  # url to comment page rss 2.0 value
               $comments = '';

commit 85916e72cd89052bc1157d7f0bb5ca98ab06dd96
Author: Gianluca Sforna <giallu@gmail.com>
Date:   Mon Dec 29 23:42:46 2008 +0100

   Improve description for user_get_name()

diff --git a/core/user_api.php b/core/user_api.php
index 88b5068..d22be35 100644
--- a/core/user_api.php
+++ b/core/user_api.php
@@ -739,7 +739,7 @@ function user_get_realname( $p_user_id ) {

 # --------------------
 # return the username or a string "user<id>" if the user does not exist
-# if show_realname is set, replace the name with a realname (if set)
+# if $g_show_realname is set and real name is not empty, return it instead
 function user_get_name( $p_user_id ) {
       $row = user_cache_row( $p_user_id, false );


-----------------------------------------------------------------------


--
Mantis Bug Tracker

------------------------------------------------------------------------------
_______________________________________________
mantisbt-cvs mailing list
mantisbt-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mantisbt-cvs