Why not use PHP_EOL?
http://us.php.net/manual/en/reserved.constants.php

On Thu, Dec 18, 2008 at 11:25 AM, <git@mantisbt.org> wrote:
The branch, master has been updated
      via  a2294e9d80d1cc2109692f6f24a4065d25806e80 (commit)
      via  c3a2fb6a709fe48fab4a8b520f5ff12832738532 (commit)
     from  4b97503a969fa08d199cf76eea8db3ef4e0eb0ef (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a2294e9d80d1cc2109692f6f24a4065d25806e80
Author: Paul Richards <paul@mantisforge.org>
Date:   Thu Dec 18 19:24:48 2008 +0000

   Rework SQL query to support mssql

commit c3a2fb6a709fe48fab4a8b520f5ff12832738532
Author: Paul Richards <paul@mantisforge.org>
Date:   Thu Dec 18 19:19:43 2008 +0000

   Use windows line feeds when logging to error log on windows

-----------------------------------------------------------------------

Summary of changes:
 core/logging_api.php |   12 ++++++++++--
 core/tag_api.php     |    9 +++++----
 2 files changed, 15 insertions(+), 6 deletions(-)

-----------------------------------------------------------------------

commit a2294e9d80d1cc2109692f6f24a4065d25806e80
Author: Paul Richards <paul@mantisforge.org>
Date:   Thu Dec 18 19:24:48 2008 +0000

   Rework SQL query to support mssql

diff --git a/core/tag_api.php b/core/tag_api.php
index 1b90036..18a3a98 100644
--- a/core/tag_api.php
+++ b/core/tag_api.php
@@ -410,14 +410,15 @@ function tag_delete( $p_tag_id ) {
 function tag_get_candidates_for_bug( $p_bug_id ) {
       $t_tag_table = db_get_table( 'mantis_tag_table' );

-       $query = 'SELECT id, name, description FROM ' . $t_tag_table;
       $t_params = array();
       if ( 0 != $p_bug_id ) {
               $t_bug_tag_table = db_get_table( 'mantis_bug_tag_table' );
-
-               $query .= "     WHERE id NOT IN (
-                                               SELECT tag_id FROM $t_bug_tag_table WHERE bug_id=" . db_param() . ' )';
+               $query = 'SELECT t.id, t.name, t.description FROM ' .
+                               $t_bug_tag_table .
+                                ' t2 LEFT JOIN ' . $t_tag_table . ' t ON t.id = t2.tag_id WHERE NOT bug_id = ' . db_param();
               $t_params[] = $p_bug_id;
+       } else {
+               $query = 'SELECT id, name, description FROM ' . $t_tag_table;
       }

       $query .= " ORDER BY name ASC ";

commit c3a2fb6a709fe48fab4a8b520f5ff12832738532
Author: Paul Richards <paul@mantisforge.org>
Date:   Thu Dec 18 19:19:43 2008 +0000

   Use windows line feeds when logging to error log on windows

diff --git a/core/logging_api.php b/core/logging_api.php
index 3205a36..13b89b9 100644
--- a/core/logging_api.php
+++ b/core/logging_api.php
@@ -63,11 +63,19 @@ function log_event( $p_level, $p_msg ) {

       switch( $t_destination ) {
               case 'file':
-                       error_log( $t_php_event . "\n", 3, $t_modifiers );
+                       if( 'WIN' == substr( PHP_OS, 0, 3 ) ) {
+                               error_log( $t_php_event . "\r\n", 3, $t_modifiers );
+                       } else {
+                               error_log( $t_php_event . "\n", 3, $t_modifiers );
+                       }
                       break;
               default:
                       # use default PHP error log settings
-                       error_log( $t_php_event . "\n" );
+                       if( 'WIN' == substr( PHP_OS, 0, 3 ) ) {
+                               error_log( $t_php_event . "\r\n" );
+                       } else {
+                               error_log( $t_php_event . "\n" );
+                       }
                       break;
       }
 }

-----------------------------------------------------------------------


--
Mantis Bug Tracker

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
mantisbt-cvs mailing list
mantisbt-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mantisbt-cvs