#455 newlist does not pass emailhost upon creation

Mailman 2.1
closed
nobody
5
2007-12-19
2007-12-04
Thijs Kinkhorst
No

Hi!

newlist does not pass emailhost to Create(), while that does support passing it, and actually uses it when passed too. In mlist.Create(), if emailhost==None, then it's
set to mm_cfg.DEFAULT_EMAIL_HOST which was probably not the intention of the list creator.

Attached patch fixes this issue. Please apply it, thanks!

Thijs

Discussion

  • Mark Sapiro
    Mark Sapiro
    2007-12-04

    • status: open --> pending
     
  • Mark Sapiro
    Mark Sapiro
    2007-12-04

    Logged In: YES
    user_id=1123998
    Originator: NO

    It is true that newlist does not pass the email host name (actually host_name, not emailhost at this point in the code) to Create(), but immediately following a successful mlist.Create(), it does:

    # Assign domain-specific attributes
    mlist.host_name = host_name
    mlist.web_page_url = web_page_url

    To set the list's host_name attribute.

    The only thing Create() uses emailhost for is to append it to the listname to make 'listname@emailhost' in order to determine that this is a valid email address, but the intent of this is to validate the listname, not the emailhost. Create() does not set any list attribute from emailhost.

     
    • status: pending --> closed
     
  • Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).