Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#446 % -> %% fix in templates/nl/private.html

Mailman 2.1
closed-accepted
nobody
5
2008-06-07
2007-05-15
Robert S.
No

The file templates/nl/private.html has WIDTH="100%" instead of WIDTH="100%%", resulting in an incorrect webpage after Mailman processed the template.

Discussion

  • A.M. Kuchling
    A.M. Kuchling
    2008-06-07

    Logged In: YES
    user_id=11375
    Originator: NO

    If this fix to escape % symbols is actually needed, we must have a lot of broken templates. rgrep '[^%]%[^(%]' templates/ reports 1378 lines with single '%' signs; surely they can't all be broken. Did we add some code that fixes single % signs?

     
  • Mark Sapiro
    Mark Sapiro
    2008-06-07

    • status: open --> closed-accepted
     
  • Mark Sapiro
    Mark Sapiro
    2008-06-07

    Logged In: YES
    user_id=1123998
    Originator: NO

    Actually, it is needed. Most of the lines with single % are in listinfo.html, options.html and roster.html templates which are processed by HtmlFormatter.ParseTags() which doesn't do % interpolation.

    Of the rest, 4 are in hu/illik.html which is spurious, 4 are of the form %25(...)s - which should probably be %(...)25s - in various zh_CN templates and 2 are in nl/private.html.

    Yesterday, I actually produced and uploaded, but didn't yet announce, a 2.1.11rc1 release. It doesn't have these fixes to nl/private.html, but they will be in the next 2.1.11 release.