From: Pavel Roskin <proski@gn...> - 2008-05-22 15:15:01
I believe we need to make some improvements to the way ath_info and
madwifi report the version and revision of the MAC chip. It's quite
confusing the way it is now.
There is just one byte that encodes both. ath_info assumes that the
upper 4 bits encode the version. But I don't see any confirmation of
The latest ah_devid.h mentions five versions: AR5210, AR5211, AR5212,
AR5213 and AR5416. Running "strings" on the latest HAL (the one with
AR5007 support) gives the same list without AR5213. But if we look at
the upper 4 bits of the IDs from ath_info, we'll see ten different
versions. For instance, AR5211 and AR5311 would have different
versions, but ah_devid.h says otherwise.
I suggest that we stop caring about the MAC version and stop displaying
it (except when HAL returns it). If we need to differ the chipsets, we
can use revisions. We can define simple inline functions checking if
the chipset provides a specific feature.
I think we need an exact match for the revision to show its name.
ath_info used to show the last revision before the actual one, but we
actually need to warn the user that the revision is not in the table and
may be untested. I fixed that in ath_info, but we need it in the driver
too (see ath5k_chip_name in ath/if_ath_hal_extensions.c)
My plan is to finish clean up in ath_info and then move the changes to
madwifi and ath5k. I'm going to kill all references to MAC versions and
possibly provide longer descriptions for the revisions.
But I'd like to get some feedback first.