Thread: [Madwifi-devel] amrr rate control
Status: Beta
Brought to you by:
otaku
From: Mathieu L. <Mat...@so...> - 2004-09-24 12:05:11
|
hi all, The attached patch implements the AMRR rate control algorithm and uses the new rate control framework developed by sam in CVS HEAD. I did perform minimal testing, namely: associate with 802.11b AP, download a big tarball from the internet, verify md5sum. I did not perform any performance measurement. To use it: - patch -p0 < amrr-6.patch - make - make install - /sbin/modprobe ath_rate_amrr - insert card It should be using the new algorithm. regards, Mathieu -- Mathieu Lacage <mat...@so...> |
From: Mathieu L. <Mat...@so...> - 2004-09-24 12:52:44
Attachments:
amrr-6.patch
|
damn. patch attached. On Fri, 2004-09-24 at 14:04, Mathieu Lacage wrote: > hi all, > > The attached patch implements the AMRR rate control algorithm and uses > the new rate control framework developed by sam in CVS HEAD. > > I did perform minimal testing, namely: associate with 802.11b AP, > download a big tarball from the internet, verify md5sum. I did not > perform any performance measurement. > > To use it: > - patch -p0 < amrr-6.patch > - make > - make install > - /sbin/modprobe ath_rate_amrr > - insert card > > It should be using the new algorithm. > > regards, > Mathieu -- Mathieu Lacage <mat...@so...> |
From: Sam L. <sa...@er...> - 2004-09-24 14:58:33
|
Thanks for getting your stuff out so quickly. Does it work to have multiple rate control modules listed for ATH_RATE in the Makefile.inc? When I test w/ an alternate algorithm I do: make clean # for old code export ATH_RATE=amrr make install I'm not sure how well depmod handles having multiple modules that define the same symbols... Sam |
From: Mathieu L. <Mat...@so...> - 2004-09-24 15:03:20
|
On Fri, 2004-09-24 at 17:01, Sam Leffler wrote: > Thanks for getting your stuff out so quickly. > > Does it work to have multiple rate control modules listed for ATH_RATE in the > Makefile.inc? When I test w/ an alternate algorithm I do: It seemed to. > > make clean # for old code > export ATH_RATE=amrr > make install I see. I thought about this shortly (about 5s) and just decided to stop trying to figure it out and then just added it into the Makefile ;-) > > I'm not sure how well depmod handles having multiple modules that define the > same symbols... Well, it seemed to work here but, as I said, I did not even give it the slightest thought. If you are okay with the patch, I will (or you will if you prefer) check it in without this snippet. thanks, Mathieu > > Sam -- Mathieu Lacage <mat...@so...> |
From: Sam L. <sa...@er...> - 2004-09-24 15:16:59
|
On Friday 24 September 2004 08:02 am, Mathieu Lacage wrote: > On Fri, 2004-09-24 at 17:01, Sam Leffler wrote: > > Thanks for getting your stuff out so quickly. > > > > Does it work to have multiple rate control modules listed for ATH_RATE in > > the Makefile.inc? When I test w/ an alternate algorithm I do: > > It seemed to. > > > make clean # for old code > > export ATH_RATE=amrr > > make install > > I see. I thought about this shortly (about 5s) and just decided to stop > trying to figure it out and then just added it into the Makefile ;-) Actually, that should have been export ATH_RATE=ath_rate/amrr for anyone planning to try it. > > > I'm not sure how well depmod handles having multiple modules that define > > the same symbols... > > Well, it seemed to work here but, as I said, I did not even give it the > slightest thought. If you are okay with the patch, I will (or you will > if you prefer) check it in without this snippet. Be sure your kernel is configured with MODVERSIONS. I had problems but can't recall if it was specific to one or a group of kernel versions. I originally wanted to have the Makefiles build all included rate control modules and then only install/use one of them but in order to not confuse depmod I found I had to build only one as otherwise it would find the other modules and rebuild the unwanted one. I believe you may be not seeing this because ammr sorts before onoe and so depmod automatically took your code. It's actually a pain to switch between rate control modules as you have to completely clear out various state or you get symbol version mismatches. Sam |
From: Mathieu L. <Mat...@so...> - 2004-09-24 15:20:20
|
On Fri, 2004-09-24 at 17:20, Sam Leffler wrote: > Actually, that should have been > > export ATH_RATE=ath_rate/amrr > > for anyone planning to try it. I recommend that one avoid cluttering your environment ATH_RATE=ath_rate/amrr make regards, Mathieu -- Mathieu Lacage <mat...@so...> |
From: Sam L. <sa...@er...> - 2004-09-24 15:24:47
|
On Friday 24 September 2004 08:19 am, Mathieu Lacage wrote: > On Fri, 2004-09-24 at 17:20, Sam Leffler wrote: > > Actually, that should have been > > > > export ATH_RATE=ath_rate/amrr > > > > for anyone planning to try it. > > I recommend that one avoid cluttering your environment > ATH_RATE=ath_rate/amrr make Except that if you build code as "you" and then want to install you need to do su ATH_RATE=ath_rate/amrr make or you'll get the default algorithm. That's why I leave it set in the environment. Sam |
From: Mathieu L. <Mat...@so...> - 2004-09-24 15:28:49
|
On Fri, 2004-09-24 at 17:27, Sam Leffler wrote: > On Friday 24 September 2004 08:19 am, Mathieu Lacage wrote: > > On Fri, 2004-09-24 at 17:20, Sam Leffler wrote: > > > Actually, that should have been > > > > > > export ATH_RATE=ath_rate/amrr > > > > > > for anyone planning to try it. > > > > I recommend that one avoid cluttering your environment > > ATH_RATE=ath_rate/amrr make > > Except that if you build code as "you" and then want to install you need to do ok, I really should use root less often :) Mathieu > > su > ATH_RATE=ath_rate/amrr make > > or you'll get the default algorithm. That's why I leave it set in the > environment. > > Sam -- Mathieu Lacage <mat...@so...> |