From: Pavel Roskin <svn-commits@ma...> - 2011-10-07 21:43:17
Project : madwifi
Revision : 4173
Author : proski (Pavel Roskin)
Date : 2011-10-07 23:43:03 +0200 (Fri, 07 Oct 2011)
Log Message :
Remove -Werror from WARNINGS
It's impossible to eliminate all warnings with all combinations of
kernels and compilers. Users are punished for using untested
combinations that should be OK. Other projects don't use -Werror and
nothing bad happens.
Future compilers would surely introduce new warnings. MadWifi doesn't
need to break because of that.
There is no way to make -Werror apply to MadWifi code but not to the
kernel headers. Linux kernel doesn't use -Werror, why should MadWifi?
Using -Werror creates a false sense of security. It's easy to assume
that the code is warning-free at least on the developers' systems.
However, broken code was committed in the past that would not compile at
all. Code quality means more that absence of warnings. It cannot be
ensured by -Werror.
* madwifi/branches/madwifi-0.9.4/Makefile.inc updated
--- madwifi/branches/madwifi-0.9.4/Makefile.inc 2011-10-07 21:42:25 UTC (rev 4172)
+++ madwifi/branches/madwifi-0.9.4/Makefile.inc 2011-10-07 21:43:03 UTC (rev 4173)
@@ -146,7 +146,7 @@
-WARNINGS = -Werror -Wall
+WARNINGS = -Wall
INCS= -include $(TOP)/include/compat.h -I$(TOP)/include