Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#22 old scrlbk ignores always-clip-spaces

closed
None
3
2001-07-18
2001-07-18
Rolf Braun
No

The flow of data regarding whether to clip trailing
spaces has changed in MacSSH from BetterTelnet; at the
same time, the way VSgettext works changed with the
2-byte patches. This combination has produced a bug, as
follows.

The internal routine VSIstrcopy used to check a global
preference as to whether trailing spaces are always
clipped; now, it only checks noClip. Before, trailing
spaces were clipped if noClip was 0 OR if the global
preference was true. Now, trailing spaces are clipped
only if noClip is 0, which doesn't happen when invoked
on a single line selection. This is fine with normal
scrollback (with saved attributes) since VSgettext does
not turn off its clipspaces variable when the global
pref is on; thus passing !clipspaces as noClip makes
the preference effective. This is absolutely fine.

Now, the bug: No such action is taken by VSOgettext,
which is used by the old (no attributes in scrollback)
code. If the selection is a single line, trailing
spaces are not clipped. This is inconsistent, and
should be fixed.

Discussion

  • Rolf Braun
    Rolf Braun
    2001-07-18

    Logged In: YES
    user_id=253224

    lowering priority since this isn't that important

     
  • Rolf Braun
    Rolf Braun
    2001-07-18

    • priority: 5 --> 3
    • assigned_to: nobody --> chombier
     
  • Logged In: YES
    user_id=158181

    VSOgettext has now a clipspaces input parameter used as in
    VSgettext.

     
    • status: open --> closed