#191 diff loses user identifier

current_cvs
closed-fixed
Andre-Littoz
8
2011-12-26
2011-12-26
Andre-Littoz
No

With current CVS version, diff removes the user symbols (those that would be marked as identifiers) in the display.

This is caused by a too specific extraction pattern failing in sub markupfile (file Markup.pm) after changes in idref: an "example" identifier link is generated, then the link skeleton around this identifier is put aside for further application on "real" identifiers. Unhappily, the extraction is based on the supposed structure of idref instead of matching only the identifier.

This regression precludes issuing a new release.

Discussion

  • Andre-Littoz
    Andre-Littoz
    2011-12-26

    • status: open --> open-fixed
     
  • Andre-Littoz
    Andre-Littoz
    2011-12-26

    Getting a reliable state transition between invocation of LXR introduced modification in the structure of the URL. Moreover, using <FORM>s to generate the URL undefines the order of the arguments in the ?-query string. Therefore any test on the URL is bound to fail if it is based on an expected ordered sequence of the arguments.

    Fix: use a generic extraction pattern in sub markupfile where a very specific identifier is submitted to sub idref. The identifier is so specific it is not expected to happen in any compliant <A> tag. For that, unfrequent punctuation characters are used.

     
  • Andre-Littoz
    Andre-Littoz
    2011-12-26

    • status: open-fixed --> closed-fixed