#165 Image files never displayed

current_cvs
closed-fixed
Andre-Littoz
Browsing (93)
5
2011-05-07
2011-03-09
Andre-Littoz
No

LXR v0.9.8

Graphic file cannot be displayed because synthesized URL is a query for LXR to process a source file instead of a simple file path.

Proposed patch for Common.pm:

-316,321 110307 (replace lines 316 to 321 with:)
&$outfun("<ul><table><tr><th valign=\"center\"><b>Image: </b></th></tr>\n");
&$outfun("<tr><td>");
&$outfun("<img src=\"$config->{virtroot}"
. $pathname
. "\" border=\"0\""
. " alt=\"$pathname cannot be displayed by this browser\">\n");
&$outfun("</td></tr></table></ul>");
--------------- end of patch -----------------

Discussion

  • Andre-Littoz
    Andre-Littoz
    2011-03-09

    • summary: Image files never dispalyed --> Image files never displayed
     
  • Andre-Littoz
    Andre-Littoz
    2011-03-09

    • status: open --> open-works-for-me
     
  • Andre-Littoz
    Andre-Littoz
    2011-03-11

    • assigned_to: nobody --> ajlittoz
     
  • Andre-Littoz
    Andre-Littoz
    2011-03-12

    This has now been fixed in CVS.

    If you can install the new version and check that it solves your
    problem, then it would be very useful.

    Thanks for reporting this defect and helping to make LXR better.

     
  • Andre-Littoz
    Andre-Littoz
    2011-03-12

    • status: open-works-for-me --> closed-fixed
     
  • Andre-Littoz
    Andre-Littoz
    2011-03-12

    Solved simultaneously with 3204085

     
  • Andre-Littoz
    Andre-Littoz
    2011-04-30

    The proposed patch does not solve the problem: LXR's DocumentRoot points to the directory where the scripts are stored, NOT to the source tree. Consequently, <img src=...> cannot serve the graphic file.
    For the plain files case, one can create a symbolic link to the source tree in the LXR directory and access the file the file through this link. The by-pass link is configured in lxr.conf.
    For the SCM cases, further thought is needed.

     
  • Andre-Littoz
    Andre-Littoz
    2011-04-30

    • status: closed-fixed --> closed-works-for-me
     
  • Andre-Littoz
    Andre-Littoz
    2011-05-07

    This has now been fixed in CVS.

    If you can install the new version and check that it solves your
    problem, then it would be very useful.

    Thanks for reporting this defect and helping to make LXR better.

     
  • Andre-Littoz
    Andre-Littoz
    2011-05-07

    • status: closed-works-for-me --> closed-fixed