#101 Postgres.pm missing a few ${prefix}es

current_cvs
closed-fixed
Malcolm Box
5
2005-04-29
2005-02-09
Anonymous
No

The sequence names in Postgres.pm need to be prefixed
with the variable which holds the naming prefix, ie lxr_

keith@apache.org

Discussion

  • Logged In: YES
    user_id=1258114

    Patch for 0.9.3 version (maybe CVS too):

    --- /home/citan/tmp/lxr-0.9.3/lib/LXR/Index/Postgres.pm Tue
    Jul 27 10:05:45 2004
    +++ /usr/local/lxr/lib/LXR/Index/Postgres.pm Tue Apr 12
    16:38:40 2005
    @@ -57,12 +57,12 @@

    $files\_select =
      $dbh->prepare\("select fileid from $\{prefix\}files where
    

    filename = ? and revision = ?");
    - $filenum_nextval = $dbh->prepare("select nextval('filenum')");
    + $filenum_nextval = $dbh->prepare("select
    nextval('${prefix}filenum')");
    $files_insert = $dbh->prepare("insert into
    ${prefix}files values (?, ?, ?)");

    $symbols\_byname = $dbh->prepare\("select symid from
    

    ${prefix}symbols where symname = ?");
    $symbols_byid = $dbh->prepare("select symname from
    ${prefix}symbols where symid = ?");
    - $symnum_nextval = $dbh->prepare("select nextval('symnum')");
    + $symnum_nextval = $dbh->prepare("select
    nextval('${prefix}symnum')");
    $symbols_insert = $dbh->prepare("insert into
    ${prefix}symbols values (?, ?)");
    $symbols_remove = $dbh->prepare("delete from
    ${prefix}symbols where symname = ?");

    @@ -99,7 +99,7 @@
    . "and f.fileid = r.fileid and "
    . "s.symname = ? and r.release = ?");

    - $declid_nextnum = $dbh->prepare("select nextval('declnum')");
    + $declid_nextnum = $dbh->prepare("select
    nextval('${prefix}declnum')");

    $decl\_select =
      $dbh->prepare\(
    
     
  • Malcolm Box
    Malcolm Box
    2005-04-29

    • assigned_to: nobody --> mbox
    • status: open --> closed-fixed
     
  • Malcolm Box
    Malcolm Box
    2005-04-29

    Logged In: YES
    user_id=215386

    As far as I can see this is fixed in the latest CVS version
    of Postgres.pm.

    Please can you confirm?

    Thanks,

    Malcolm

     
  • Malcolm Box
    Malcolm Box
    2005-04-30

    Logged In: YES
    user_id=215386

    Yes, I missed those.

    Should now be fixed in CVS