#96 GPicView: Proper next/previous switching in RTL locales

closed
None
5
2009-04-05
2009-02-18
Khaled Hosny
No

In RTL locales like Arabic, the notation of previous/next is reversed, so right arrow should switch to previous image and vice versa.

The attached patch ensures image switching is handled correctly.

The only remaining issue is the popup menu which still shows the reversed arrow (GDK_leftarrow should be GDK_rightarrow and vice versa), I did several attempts like defining a new variables nextarrow/prevarrow that depend on the widget direction for its value, but, because of the way menus are constructed, I always get "initializer element is not constant" errors.

Discussion

  • Khaled Hosny
    Khaled Hosny
    2009-02-18

    Patch

     
    Attachments
  • Khaled Hosny
    Khaled Hosny
    2009-02-18

    For clarification (I think my description is bit ambiguous), I'm talking about switching images using right/left keyboard arrows as right/left mouse scrolling.

     
    • assigned_to: nobody --> juergenhoetzel
     
  • Fixed in SVN trunk: Thanks for your contribution

     
    • status: open --> closed