From: Tom R. <tr...@ke...> - 2005-02-25 19:09:51
|
On Fri, Feb 25, 2005 at 11:04:24AM -0800, David S. Miller wrote: > On Fri, 25 Feb 2005 10:56:03 -0700 > Tom Rini <tr...@ke...> wrote: > > > Putting on my MontaVista hat, we've switched to this internally for > > upcoming stuff, and have seen only a small number of things break (stuff > > related to <asm-i386/processor.h>, which is the real problem of > > <asm-i386/atomic.h>) and only 1 thing was 'valid' (MIPS allows for page > > size to be configured, which is PAGE_SHIFT/etc which seems to be a valid > > thing to export to userland :)). > > Precisely for this reason it is not. getpagesize() should be used > for things that want to use the current system PAGE_SIZE. A quick grep makes it look like only MIPS lets you configure the PAGE_SHIFT (and thus change PAGE_SIZE) and therefore need a non-empty <linux/autoconf.h>. Is there something I'm missing? Or are there other cases I'm not seeing? Thanks. -- Tom Rini http://gate.crashing.org/~trini/ |