From: <ch...@su...> - 2013-06-25 12:47:25
|
Hi! > > This part of the code seems to be repeated several times. What about > > making it into library code in lib/tst_fill_file.c instead? > > > > Something like: > > > > tst_fill_file(const char *path, char pattern, size_t bs, size_t count); > > > > And I would open the and write the file directly rather than doing > > system("dd ..."); > > > > Agreed. But my intent was to make a little "fix" not introducing any > extra logic to these test. > > Ok, I'll rewrite this. Thanks. -- Cyril Hrubis ch...@su... |