Re: [LTP] [PATCH] syscalls/cma: add runtime check to setup()

[Mike F. <va...@ge...>]

On Wednesday 24 April 2013 02:53:52 Jan Stancek wrote:
> From: "Mike Frysinger" <va...@ge...>
> > On Tuesday 23 April 2013 04:17:15 Jan Stancek wrote:
> > > __NR_process_vm_readv / __NR_process_vm_writev defined doesn't
> > > guarantee, that kernel supports these syscalls. Add check to setup(),
> > > which uses ltp_syscall(). If syscall isn't supported it will
> > > end the testcase with TCONF.
> > 
> > delete all the "#else" branches since you're now using
> > linux_syscall_numbers.h
> 
> Without that check in parent, you can end up in situation where some child
> aborts first and then parent reports failure. By doing it early in setup()
> you can avoid allocating resources that won't go away when process later
> terminates with TCONF.

by including linux_syscall_numbers.h, you've guaranteed that 
__NR_process_vm_readv will always be defined, thus the code under "#ifndef 
__NR_process_vm_readv" will never be run, thus you should delete it.
-mike