Re: [LTP] [PATCH] kill05: fix regression

[Cyril H. <ch...@su...>]

Hi!
> you're right. In fact, the problem is in safe_getpwnam(), which does not
> correctly reproduce the behavior of the deprecated my_getpwnam().
> Moreover, I'm not noticing the problem on my laptop due to a race
> condition in kill05, while it shows an inconsistent behavior on the box
> I'm running tests on (mipsel with glibc, for the sake).
> 
> Could you please fix safe_getpwnam() with either one of the following
> patches?

Technically you are right, but my_getpwnam() behaviour is broken too. As
the strings the structure is pointing to are statically allocated too,
this copying preserves only uid and gid. So instead of creating
crippled interface we will rather fix the test itself.

Thanks the report anyway.

-- 
Cyril Hrubis
ch...@su...