Re: [LTP] [PATCH v4] [syscalls] io_submit: fix broken testcase

[Masatake Y. <ya...@re...>]

> 
> io_submit01 contains 4 negative testing: EINVAL, EFAULT, EINVAL+EFAULT
> and EBADF. The first 3 testcases didn't initialize the content of 'ctx'
> so that they contained invalid argument in the cases. This may cause
> incorrect result on some architectures, like:
> 
> io_submit01    1  TPASS  :  expected failure - returned value = 22 : Invalid argument
> io_submit01    2  TFAIL  :  unexpected returned value - -22 - expected -14
> io_submit01    3  TPASS  :  expected failure - returned value = 22 : Invalid argument
> io_submit01    4  TPASS  :  expected failure - returned value = 9 : Bad file descriptor
> 
> I fixed this issue by moving the initialization of ctx before the cases,
> also added some additional negative + positive cases. Now tested on x86
> and s390x system, the results seem good:
> 
> io_submit01    1  TPASS  :  expected failure - returned value = -22 : Invalid argument
> io_submit01    2  TPASS  :  expected failure - returned value = -22 : Invalid argument
> io_submit01    3  TPASS  :  expected failure - returned value = -22 : Invalid argument
> io_submit01    4  TPASS  :  expected failure - returned value = -14 : Bad address
> io_submit01    5  TPASS  :  expected failure - returned value = -22 : Invalid argument
> io_submit01    6  TPASS  :  expected failure - returned value = -9 : Bad file descriptor
> io_submit01    7  TPASS  :  expected success - returned value = 0
> io_submit01    8  TPASS  :  expected success - returned value = 1
> 
> v2: use tempfile instead of read /etc/fstab directly
> v3: add a function to check results
> v4: code style improvement
> 
> Signed-off-by: Caspar Zhang <cz...@re...>
> ---
>  testcases/kernel/syscalls/io_submit/io_submit01.c |  190 +++++++++++----------
>  1 files changed, 100 insertions(+), 90 deletions(-)
> 

Looks good.

Reviewed-by: Masatake YAMATO <ya...@re...>