From: Mike F. <va...@ge...> - 2008-11-18 14:01:59
|
On Tuesday 18 November 2008 02:34:32 Gilles.Carry wrote: > Mike Frysinger a écrit : > > On Monday 17 November 2008 10:21:04 Gilles.Carry wrote: > >> I recently had the case where a test fails with something like this: > >> FAIL : hugeshmget01 call failed - errno = 38 : Function not > >> implemented This shows up as I don't use CONFIG_HUGETLBFS in my kernel. > >> > >> Maybe this has already been discussed but how about including kernel > >> config headers into LTP to avoid such irrelevant report? > >> > >> Thoughts? > > > > kernel config options change. you also cant assume the kernel location > > (diff kernel source, cross-compile, etc...). > > Of course they change, like the rest of the kernel! > When I say "include kernel config headers", I mean copy autoconf.h to > ltp before compiling, not include it into LTP source tree. which doesnt address anything of what i said. when a kernel config gets renamed, the tests that refer to it need updating. > > why not just turn the TFAIL into TCONF when the function returns ENOSYS > > in the tests that concern you. > > Because some might want to check if the functionality is present in the > kernel and consider ENOSYS as a failure. This is why it must be optional. TCONF outputs a message. if you really care, read the output. -mike |