Re: [LTP] [PATCH] Eliminate arch-dependent code in syscalls/ipc/shmat series

[Helge D. <de...@gm...>]

Subrata Modak wrote:
> On Mon, 2008-05-19 at 19:26 +0800, Roy Lee wrote:
>> 2008/5/19, Subrata Modak <su...@li...>:
>>
>>> Well this breaks my compilation even on a i386 system. See the
>>> compilation error:
>>>
>>> cc -Wall  -I../../include -g -Wall -I../lib -I../../../../../include
>>> -Wall    shmat01.c  -L../../../../../lib -lltp -L.. -lipc -o shmat01
>>> shmat01.c:84: error: initializer element is not constant
>>> shmat01.c:84: error: (near initialization for 'TC[1].offset')
>>> shmat01.c: In function 'setup':
>>> shmat01.c:259: warning: comparison between pointer and integer
>>> make[5]: *** [shmat01] Error 1
>>>
>> Oops, I forgot that some architectures define their SHMLBA as getpagesize(),
>> which may be implemented as a function and cannot be used to
>> initialize static data.
>>
>> Could you try this one?  Thanks.
> 
> Thanks. This builds fine now. Committed to CVS.

Hello Subrata,
Hello Roy,

this patch broke parisc (which has really some strange requirements).
Attached patch fixes it. If it's OK for you, please apply.

Helge