Re: [LTP] =?utf-8?q?Today=C5=9B_Snapshot=3A_var=5Fargs?=

[Randy D. <rd...@xe...>]

On Mon, 17 Sep 2007 14:15:49 -0700 Andrew Morton wrote:

> On Fri, 07 Sep 2007 15:22:32 +0530
> Subrata Modak <su...@li...> wrote:
> 
> > Hi,
> > You can pick up todayś snapshot (ltp-nightly-snapshot_07-09-2007.tgz)
> > of LTP from:
> > http://sourceforge.net/project/showfiles.php?group_id=3382&package_id=3308&release_id=535958
> > 
> > It differs from earlier snapshot (ltp-nightly-snapshot_04-09-2007.tgz)
> > by:
> > 1) Removal of Connectathon testcases
> > 2) Updation of KDUMP Installation Script errors
> 
> ltp-full-20070831 has a printf problem:
> 
> pth_str03    0  INFO  :  thread %d exiting, depth=%d, status=%d, addr=%p
> pth_str03    0  INFO  :  thread %d exiting, depth=%d, status=%d, addr=%p

---
The var_args expander in lib/tst_res.c is easily confused.

Sometimes the varargs expander decides that it shouldn't expand more varargs.
This fixes pth_str03 output but may adversely affect other test output.

This patch identifies the problem.
I'll run a full LTP test run both with and without the patch and compare the
output files, but if anyone has a better patch for the varargs expander,
that would be nice too.

---

 lib/tst_res.c |    1 -
 1 file changed, 1 deletion(-)

diff -Naurp ltp-full-20070831/lib/tst_res.c.org ltp-full-20070831/lib/tst_res.c
--- ltp-full-20070831/lib/tst_res.c.org	2007-08-30 01:33:28.000000000 -0700
+++ ltp-full-20070831/lib/tst_res.c	2007-09-18 08:45:21.000000000 -0700
@@ -139,7 +139,6 @@
          va_start(ap, arg_fmt);           \
          vsprintf(str, arg_fmt, ap);      \
          va_end(ap);                      \
-         Expand_varargs = FALSE;          \
       } else {                            \
          strcpy(str, arg_fmt);            \
       }                                   \
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***